Commit graph

77 commits

Author SHA1 Message Date
Bradley M. Kuhn
5868b7c22f Second payment amount changed in 2018-12 round. 2019-02-28 16:42:15 -08:00
Bradley M. Kuhn
9650769fee Correct approvalTag setting for payments > 1
This implementation was simply incomplete in an earlier commit.
2019-02-28 16:41:16 -08:00
Bradley M. Kuhn
f1ed2eb991 Remove check to see if payment-N-approved set.
The Python script save-feedback.py now sets payment-N-approved, so this
script will run against tickets that are in needs-project-ok state and
payment-N-approved is set (for now, anyway).
2019-02-28 16:36:32 -08:00
Bradley M. Kuhn
e5bf1e9f90 Approvals no longer in files, but in the ticket comments.
This script was originally written to handle the approval data appearing in
files in a directory rather than the ticket traffic itself.  This change
reworks that so that the script is always processing a group of tickets, and
searches for payment approval in the ticket traffic itself.

Note that this change is not yet secure, as the interns, if they know format,
could "approve themselves".  The "security" comes from the script before (or
a by hand action with someone with RT access to set the completed-internship
field to 'payment-N-approved'.
2019-02-28 16:22:07 -08:00
Bradley M. Kuhn
6a659c102c Various improvements made and not properly recorded.
I made various improvements quickly while processing payment 1 in 2018-12 and
this is the result.  I didn't commit incrementally, but I do now see that I
added the support for activating the travel ticket and some error message
cleanup.
2019-02-28 14:40:09 -08:00
Bradley M. Kuhn
bf631e8259 Various changes to support Payment 1
My initial drafting of this script could not support Payment 1 properly, as I
started the script after Payment 1 in 2018-05 round was already done.

These changes, while not yet fully tested, probably should work to handle
Payment 1 tickets.
2019-01-14 09:26:21 -08:00
Bradley M. Kuhn
950d3d374f First draft of script to set deadline past last correspondence. 2018-10-08 14:44:34 -07:00
Bradley M. Kuhn
b301b2a86e Improve payment output prep. 2018-09-22 17:30:44 -07:00
Bradley M. Kuhn
9145aec8c5 Correct link command. 2018-09-22 17:30:25 -07:00
Bradley M. Kuhn
c385cda4e4 Find payment details in ticket traffic from previous. 2018-09-22 17:29:44 -07:00
Bradley M. Kuhn
77f47bb9e1 Correct search terms function call. 2018-09-22 17:28:45 -07:00
Bradley M. Kuhn
afb3bbc340 Handle activated travel reimbursement tickets properly.
Travel reimbursement tickets might already be activated.  We track activation
by leaving them to "dependson" the main travel ticket, and hav them only
refersto relationship once activated.

In cases where the dependson link does not exist, then we should send notice
upon failure when rejecting the ticket.
2018-09-12 15:57:53 -07:00
Bradley M. Kuhn
c3a368d29f Ensure payment number is in ledger entry. 2018-09-12 15:57:44 -07:00
Bradley M. Kuhn
90618aba6a print a message & exit when there are no tickets to do. 2018-08-23 13:53:32 -07:00
Bradley M. Kuhn
4b0cdad67e Debugging output and skip blank lines, with comment. 2018-08-23 13:53:13 -07:00
Bradley M. Kuhn
6b8f3fac77 payment method only unknown when not defined
Assure reassignment of variable only happens inside conditional.
2018-08-07 10:32:09 -07:00
Bradley M. Kuhn
d6375aefd6 Fix verbose message and link setup. 2018-08-07 10:29:25 -07:00
Bradley M. Kuhn
56441180e4 warn rather than die when payment method not found.
We still want to pay ready-for-payment tickets that have no payment method
found.
2018-08-07 10:28:40 -07:00
Bradley M. Kuhn
e003313256 Write new script for activating the travel tickets for Outreachy 2018-08-05 19:54:28 -07:00
Bradley M. Kuhn
d1dc3fb8c3 Fix function and add verbosity.
This wasn't functioning right after my last changes, but this should get it
working.
2018-08-05 19:54:13 -07:00
Bradley M. Kuhn
c7811bacb9 Correct spelling. 2018-08-05 19:53:56 -07:00
Bradley M. Kuhn
608477135d Adapt function to take round as an argument. 2018-08-05 19:28:36 -07:00
Bradley M. Kuhn
5d074729bd FindReimbursementTicketFromList: move to rt-helper.pl 2018-08-05 19:27:11 -07:00
Bradley M. Kuhn
38f7b0cedc Rework GetLinksForTicket, returns hash now
Include the Hash Id.
2018-08-05 19:15:51 -07:00
Bradley M. Kuhn
c87c215a87 First draft of sanity check script. 2018-07-25 14:46:14 -07:00
Bradley M. Kuhn
532b21575a Remove spurious prints. 2018-07-25 14:46:07 -07:00
Bradley M. Kuhn
9867531a53 Make $round an argument to this sub.
Also, add $RT_CMD as an "our" variable.
2018-07-25 14:33:00 -07:00
Bradley M. Kuhn
7e52b5922b Move PaymentDateByTicket to helper file. 2018-07-25 14:02:12 -07:00
Bradley M. Kuhn
cc60ef0326 Create new function for all tickets in Outreachy round. 2018-07-25 14:01:36 -07:00
Bradley M. Kuhn
0263c49c77 Move two functions to helper file. 2018-07-25 13:58:44 -07:00
Bradley M. Kuhn
5e0433d39b paymentMethod should be lower case. 2018-07-25 13:57:27 -07:00
Bradley M. Kuhn
34e00ca5f0 Create rt-helper.pl and move one function to it.
Move function to rt-helper.pl that might be used in other Perl scripts.
2018-07-25 13:57:02 -07:00
Bradley M. Kuhn
c9c3b8b01e I forgot map returns the last item in its block.
I want what $_ became, not the "1" returned from the s/// :)
2018-07-25 09:49:50 -07:00
Bradley M. Kuhn
e11ceab5dd Do not be so strict on this regex. 2018-07-25 09:49:34 -07:00
Bradley M. Kuhn
2e8f9c42d1 Correct rt show output; add verbosity there.
Note that "rt show ticket/NUMBER" does not give the entire ticket traffic,
whereas "rt show NUMBER" does.
2018-07-25 09:44:19 -07:00
Bradley M. Kuhn
c1fdf916d9 Fix typo. 2018-07-25 09:44:14 -07:00
Bradley M. Kuhn
7ec2c7a291 First draft of the bulk-prep-pay script. 2018-07-25 09:40:30 -07:00
Bradley M. Kuhn
052d32fc5e Add Travel notice ticket link, and fix RT commands. 2018-07-25 09:40:19 -07:00
Bradley M. Kuhn
5697b6beee Add --round CLI argument; use that round for search criterion. 2018-07-22 19:25:49 -07:00
Bradley M. Kuhn
8aa05bff6d Allow FIXME_INVOICE_DATE in document templates. 2018-07-22 19:25:42 -07:00
Bradley M. Kuhn
9cb57fe776 Complete script, improving error messages. 2018-07-22 18:49:06 -07:00
Bradley M. Kuhn
421dd769cb Match better what is typical in the ticket subject 2018-07-22 18:05:23 -07:00
Bradley M. Kuhn
5c28767692 Remove unnecessary my 2018-07-22 16:36:07 -07:00
Bradley M. Kuhn
c0e328dccf Add files for correspondence. 2018-07-22 16:35:55 -07:00
Bradley M. Kuhn
48ec393a01 Support lookup of reimbursement ticket 2018-07-22 16:35:35 -07:00
Bradley M. Kuhn
dcbf4bac2c autodie on everything. 2018-07-22 16:02:13 -07:00
Bradley M. Kuhn
5936b5eec5 Improve output. 2018-07-22 16:02:07 -07:00
Bradley M. Kuhn
ace578089c count old interns. 2018-07-22 15:31:18 -07:00
Bradley M. Kuhn
467522f331 Add pay date to error output. 2018-07-22 15:22:25 -07:00
Bradley M. Kuhn
f00819a174 Correct tax ticket processing. 2018-07-22 15:22:16 -07:00