Commit graph

92 commits

Author SHA1 Message Date
Bradley M. Kuhn
7d24d42788 Change regex to handle currency conversation USD hint.
I found a ticket today with payment-amount set as:

   "CUR AMOUNT ($OTHER_AMOUNT)"

Since the field is free-from I figured I probably need to accept
this.
2020-09-15 11:25:08 -07:00
Bradley M. Kuhn
927bb55547 Correct copyright year; I had cut and pasted and forgot.
All this was code I just wrote a few minutes ago, so the year is
2020.
2020-07-21 13:55:29 -07:00
Bradley M. Kuhn
a85a3777b3 Rename script 2020-07-21 13:51:56 -07:00
Bradley M. Kuhn
6c2d685116 Rework to handle new format of custom fields for payment methods. 2020-07-21 13:50:43 -07:00
Bradley M. Kuhn
880da9360c Additional verbosity. 2020-07-21 13:50:27 -07:00
Bradley M. Kuhn
ca31ce7c8f Don't autodie if this has a problem. 2020-07-21 13:50:14 -07:00
Bradley M. Kuhn
877f50996f Add note. 2020-07-21 13:50:03 -07:00
Bradley M. Kuhn
5a16830b12 Cleanup key. 2020-07-21 13:49:52 -07:00
Bradley M. Kuhn
11d060a2fa rt-reassign: script to reassign tickets.
This assumes a set of ticket ids on STDIN and reassigns them if
they're open and in the queue specified on the CLI.
2020-07-21 13:48:58 -07:00
Bradley M. Kuhn
8ac2663124 Improve totals and subtotals output amounts
Various changes that I did a while ago to better support totals and
subtotals output.
2020-06-22 10:18:30 -07:00
Bradley M. Kuhn
b5bb608067 Support --subTotals option for each payment method.
--subTotals implies --showAmounts, and when you use it, the ticket amounts
are grouped by payment type, and the subtotal for each payment type is
printed.

Note that I left some code duplication in the $subTotalOk / $overallTotalOk
support stuff.  It was just laziness.  There should be a sub that tests the
values for validity.
2020-04-09 09:52:04 -07:00
Bradley M. Kuhn
df7362f6b9 Show total amounts for the whole group and for each ticket. 2020-04-09 09:33:26 -07:00
Bradley M. Kuhn
01decbbd55 Make Query String a CLI option; leave defaults of interest. 2020-04-09 09:32:22 -07:00
Bradley M. Kuhn
4775799a99 Fix evaluation of ticket traffic to find right mentor.
The regex /^\s*([^:]+)\s*:\s*(.+)$/ is very overzealous, so use it last; find
all the other stuff we want first.
2019-04-07 21:26:19 -07:00
Bradley M. Kuhn
6ed5c75d85 Improve parsing of feedback. 2019-04-07 20:58:03 -07:00
Bradley M. Kuhn
d352fc5322 Improve output. 2019-04-07 20:57:52 -07:00
Bradley M. Kuhn
2b06c9f8bd Correct amount of final payment. 2019-04-07 20:57:19 -07:00
Bradley M. Kuhn
5868b7c22f Second payment amount changed in 2018-12 round. 2019-02-28 16:42:15 -08:00
Bradley M. Kuhn
9650769fee Correct approvalTag setting for payments > 1
This implementation was simply incomplete in an earlier commit.
2019-02-28 16:41:16 -08:00
Bradley M. Kuhn
f1ed2eb991 Remove check to see if payment-N-approved set.
The Python script save-feedback.py now sets payment-N-approved, so this
script will run against tickets that are in needs-project-ok state and
payment-N-approved is set (for now, anyway).
2019-02-28 16:36:32 -08:00
Bradley M. Kuhn
e5bf1e9f90 Approvals no longer in files, but in the ticket comments.
This script was originally written to handle the approval data appearing in
files in a directory rather than the ticket traffic itself.  This change
reworks that so that the script is always processing a group of tickets, and
searches for payment approval in the ticket traffic itself.

Note that this change is not yet secure, as the interns, if they know format,
could "approve themselves".  The "security" comes from the script before (or
a by hand action with someone with RT access to set the completed-internship
field to 'payment-N-approved'.
2019-02-28 16:22:07 -08:00
Bradley M. Kuhn
6a659c102c Various improvements made and not properly recorded.
I made various improvements quickly while processing payment 1 in 2018-12 and
this is the result.  I didn't commit incrementally, but I do now see that I
added the support for activating the travel ticket and some error message
cleanup.
2019-02-28 14:40:09 -08:00
Bradley M. Kuhn
bf631e8259 Various changes to support Payment 1
My initial drafting of this script could not support Payment 1 properly, as I
started the script after Payment 1 in 2018-05 round was already done.

These changes, while not yet fully tested, probably should work to handle
Payment 1 tickets.
2019-01-14 09:26:21 -08:00
Bradley M. Kuhn
950d3d374f First draft of script to set deadline past last correspondence. 2018-10-08 14:44:34 -07:00
Bradley M. Kuhn
b301b2a86e Improve payment output prep. 2018-09-22 17:30:44 -07:00
Bradley M. Kuhn
9145aec8c5 Correct link command. 2018-09-22 17:30:25 -07:00
Bradley M. Kuhn
c385cda4e4 Find payment details in ticket traffic from previous. 2018-09-22 17:29:44 -07:00
Bradley M. Kuhn
77f47bb9e1 Correct search terms function call. 2018-09-22 17:28:45 -07:00
Bradley M. Kuhn
afb3bbc340 Handle activated travel reimbursement tickets properly.
Travel reimbursement tickets might already be activated.  We track activation
by leaving them to "dependson" the main travel ticket, and hav them only
refersto relationship once activated.

In cases where the dependson link does not exist, then we should send notice
upon failure when rejecting the ticket.
2018-09-12 15:57:53 -07:00
Bradley M. Kuhn
c3a368d29f Ensure payment number is in ledger entry. 2018-09-12 15:57:44 -07:00
Bradley M. Kuhn
90618aba6a print a message & exit when there are no tickets to do. 2018-08-23 13:53:32 -07:00
Bradley M. Kuhn
4b0cdad67e Debugging output and skip blank lines, with comment. 2018-08-23 13:53:13 -07:00
Bradley M. Kuhn
6b8f3fac77 payment method only unknown when not defined
Assure reassignment of variable only happens inside conditional.
2018-08-07 10:32:09 -07:00
Bradley M. Kuhn
d6375aefd6 Fix verbose message and link setup. 2018-08-07 10:29:25 -07:00
Bradley M. Kuhn
56441180e4 warn rather than die when payment method not found.
We still want to pay ready-for-payment tickets that have no payment method
found.
2018-08-07 10:28:40 -07:00
Bradley M. Kuhn
e003313256 Write new script for activating the travel tickets for Outreachy 2018-08-05 19:54:28 -07:00
Bradley M. Kuhn
d1dc3fb8c3 Fix function and add verbosity.
This wasn't functioning right after my last changes, but this should get it
working.
2018-08-05 19:54:13 -07:00
Bradley M. Kuhn
c7811bacb9 Correct spelling. 2018-08-05 19:53:56 -07:00
Bradley M. Kuhn
608477135d Adapt function to take round as an argument. 2018-08-05 19:28:36 -07:00
Bradley M. Kuhn
5d074729bd FindReimbursementTicketFromList: move to rt-helper.pl 2018-08-05 19:27:11 -07:00
Bradley M. Kuhn
38f7b0cedc Rework GetLinksForTicket, returns hash now
Include the Hash Id.
2018-08-05 19:15:51 -07:00
Bradley M. Kuhn
c87c215a87 First draft of sanity check script. 2018-07-25 14:46:14 -07:00
Bradley M. Kuhn
532b21575a Remove spurious prints. 2018-07-25 14:46:07 -07:00
Bradley M. Kuhn
9867531a53 Make $round an argument to this sub.
Also, add $RT_CMD as an "our" variable.
2018-07-25 14:33:00 -07:00
Bradley M. Kuhn
7e52b5922b Move PaymentDateByTicket to helper file. 2018-07-25 14:02:12 -07:00
Bradley M. Kuhn
cc60ef0326 Create new function for all tickets in Outreachy round. 2018-07-25 14:01:36 -07:00
Bradley M. Kuhn
0263c49c77 Move two functions to helper file. 2018-07-25 13:58:44 -07:00
Bradley M. Kuhn
5e0433d39b paymentMethod should be lower case. 2018-07-25 13:57:27 -07:00
Bradley M. Kuhn
34e00ca5f0 Create rt-helper.pl and move one function to it.
Move function to rt-helper.pl that might be used in other Perl scripts.
2018-07-25 13:57:02 -07:00
Bradley M. Kuhn
c9c3b8b01e I forgot map returns the last item in its block.
I want what $_ became, not the "1" returned from the s/// :)
2018-07-25 09:49:50 -07:00