RT-Plugins/RT-Client-Tools
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Correct approvalTag setting for payments > 1

Browse source 
This implementation was simply incomplete in an earlier commit.
This commit is contained in:
Bradley M. Kuhn 2019-02-28 16:41:16 -08:00
parent f1ed2eb991
commit 9650769fee
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
scripts/rt-outreachy-payment-next.plx
View file

@ -256,7 +256,8 @@ foreach my $ticket (@processList) {
last; last;
} }
} }
$approvalTag = " ;Approval: rt://ticket/${ticketNum}/attachments/"; $approvalTag = " ;Approval: rt://ticket/${ticketNum}/attachments/$ {attachmentNum}"
if defined $attachmentNum;
} }
} }
close $logFH; close $logFH;
@ -268,6 +269,10 @@ foreach my $ticket (@processList) {
print STDERR "\"$ticket\": Skipping: there was a pass here for this payment, but unable to find mentor evaluation date for that pass." ; print STDERR "\"$ticket\": Skipping: there was a pass here for this payment, but unable to find mentor evaluation date for that pass." ;
next; next;
} }
if ($pass and not defined $approvalTag) {
print STDERR "\"$ticket\": Skipping: there was a pass here for this payment, but unable to the attachment number of the approval tag." ;
next;
}
my $completedInternshipField = GetCustomFieldForTicket($ticket, "completed-internship"); my $completedInternshipField = GetCustomFieldForTicket($ticket, "completed-internship");
if (not defined $completedInternshipField) { if (not defined $completedInternshipField) {
print STDERR "\"$ticket\": FIELD-NOT-FOUND: Skipping: cannot determine Entity from ticket.\n" ; print STDERR "\"$ticket\": FIELD-NOT-FOUND: Skipping: cannot determine Entity from ticket.\n" ;