Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
335 commits 1 branch 0 tags 520 KiB
Commit graph

194 commits

Author SHA1 Message Date
Bradley M. Kuhn
2a374b957e Correct off-by-one error in counter. 
The counter should be incremented/decremented after testing its value,
not before.
 2015-12-14 17:20:17 -08:00
Bradley M. Kuhn
45570a5db0 Wrap dbh->begin_work & dbh->commit 
I want to be able to nest begin_work()/commit() calls.  Years ago (in
the mid-1990s), when I did database programming, this is how we handled
this scenario.  I have no idea if there is now a "better way" to do
this, but some quick net searches found nothing that is recommended, but
I admittedly didn't search that hard.

This should work for our needs.
 2015-12-14 17:16:35 -08:00
Bradley M. Kuhn
6b8d79553b Test various database integrity questions. 
This new section of tests verifies that when the database disappears
underneath or has other types of problems that the API still functions
as expected.

The second test committed herein currently fails.
 2015-12-14 17:05:42 -08:00
Bradley M. Kuhn
6bbb59c36a Test to verify email address mapping created. 
This currently fails; addSupporter() must be corrected.
 2015-12-14 16:43:47 -08:00
Bradley M. Kuhn
69945c2704 Implementation of getRequestConfigurations 
A basic implementation of getRequestConfigurations and tests to go with
it.

Also added here is the test to verify that no items are added when
duplicates are included.
 2015-12-13 14:06:22 -08:00
Bradley M. Kuhn
4331093cee Basic implementation of addRequestConfigurations 
Adjusted one test slightly: there was a missing argument.  Also,
corrected test count.

While implementing, I realized a failure mode that forces a rollback:
duplication on the input list of configurations.  Tests are now needed
for that.
 2015-12-13 13:37:52 -08:00
Bradley M. Kuhn
63af394ca6 Tests for an operation addRequestConfigurations 
These tests currently fail; will write code next.
 2015-12-13 13:28:38 -08:00
Bradley M. Kuhn
f0f6c6978c Properly add my email address. 2015-12-13 13:07:44 -08:00
Bradley M. Kuhn
dc12600b70 Correct license specification in Makefile.PL 
But note this is AGPLv3-or-later.
 2015-12-13 13:07:36 -08:00
Bradley M. Kuhn
ae9685d16b Automatically call test suite on Emacs M-x compile 2015-12-13 13:04:53 -08:00
Bradley M. Kuhn
735db56d47 Begin implementation of addRequestConfigurations 
Includes some modifications to reuse data from previous tests.
 2015-12-13 13:04:27 -08:00
Bradley M. Kuhn
8fd03e8e6f Fail causes on getRequestConfigurations. 2015-12-13 12:50:08 -08:00
Bradley M. Kuhn
b5954e391e Correct test to actually test not-found case. 
It was always going to pass no matter what the other way it was written.
 2015-12-13 12:32:36 -08:00
Bradley M. Kuhn
4df468bb1b New test for addSupporter's addEmailAddress call 2015-12-13 12:31:54 -08:00
Bradley M. Kuhn
19d513280f addRequestType and getRequestType methods. 
Including tests for both.
 2015-12-13 12:16:14 -08:00
Bradley M. Kuhn
bf4d5d8b23 Fix number of arguments on _verifyId in prototype. 2015-12-13 12:15:50 -08:00
Bradley M. Kuhn
b34de3c1da Verify email address format with external module. 2015-12-11 18:32:59 -08:00
Bradley M. Kuhn
9e2359ed72 Test to verify addEmailAddress returns a valid id. 2015-12-11 18:23:24 -08:00
Bradley M. Kuhn
5b07fe6af9 Actual email address add code; tests stay same. 2015-12-11 18:19:25 -08:00
Bradley M. Kuhn
b1436e037e addEmailAddress: call addAddressType underneath 
address_type is added automatically from the addEmailAddress call.
Since addAddressType does a lookup first, this should not cause
duplicates.
 2015-12-09 19:56:22 -08:00
Bradley M. Kuhn
63383eef02 Correct messages. 2015-12-09 19:53:20 -08:00
Bradley M. Kuhn
d059523830 Make variable name more descriptive. 2015-12-09 19:52:31 -08:00
Bradley M. Kuhn
6d62cdeb6c Correct these tests to actually test right thing. 
They were die'ing, alright, but not for the right reason.
 2015-12-09 19:50:02 -08:00
Bradley M. Kuhn
a3aafac44a addAddressType: initial implementation & unit test 2015-12-09 19:48:59 -08:00
Bradley M. Kuhn
a1df7fc544 Reorganize documentation an order of tests. 
Make this a little easier to find.
 2015-12-09 19:38:22 -08:00
Bradley M. Kuhn
b0d7639bc3 Remove stray use command, likely bad paste. 2015-12-09 19:37:36 -08:00
Bradley M. Kuhn
ba6843e21e Begin work on addEmailAddress method. 
Basic stub and a few tests.
 2015-12-09 19:17:46 -08:00
Bradley M. Kuhn
2c14c20db9 Change comment at top. 2015-12-09 18:39:40 -08:00
Bradley M. Kuhn
587144f03e _verifyId method: initial implementation. 
Internal method for use to verify that an id we have really is in the
database.

For use before other operations.
 2015-12-09 18:39:18 -08:00
Bradley M. Kuhn
de7b145ac3 Some documentation for existing methods. 2015-12-09 18:37:26 -08:00
Bradley M. Kuhn
03b1ac5436 Add local variables for Emacs. 2015-12-09 18:36:57 -08:00
Bradley M. Kuhn
c86256d005 Initial basic support for creating a new Supporter. 
This is incomplete as of yet, since it doesn't properly set up other
tables.
 2015-12-09 16:06:07 -08:00
Bradley M. Kuhn
70ad0b8b30 Initial basic support for creating a new Supporter. 
This is incomplete as of yet, since it doesn't properly set up other
tables.
 2015-12-09 15:44:05 -08:00
Bradley M. Kuhn
3d672d1f68 Correct arguments to method; add public_ack 2015-12-06 19:24:10 -08:00
Bradley M. Kuhn
afc15507fb Put method name in test strings. 2015-12-06 19:08:29 -08:00
Bradley M. Kuhn
62d7ae0dbd sub is needed to make this work, I think. 2015-12-06 19:07:34 -08:00
Bradley M. Kuhn
a06d4a63fa Give these tests a name. 2015-12-06 19:07:30 -08:00
Bradley M. Kuhn
fc22b9a3cc Begin writing addSupporter method. 
ledger_entity_id is required.
 2015-12-06 18:56:59 -08:00
Bradley M. Kuhn
0fa986a76f Shorten variable name. 2015-12-06 18:55:01 -08:00
Bradley M. Kuhn
9d864172e5 Add dependencies. 2015-12-06 18:54:38 -08:00
Bradley M. Kuhn
fa52370f53 Initial creation code and tests. 2015-12-06 18:28:49 -08:00
Bradley M. Kuhn
99c637f167 This is already version 0.2 2015-12-06 17:27:25 -08:00
Bradley M. Kuhn
be753d5b3d Wrote basic documentation. 2015-12-06 17:27:13 -08:00
Bradley M. Kuhn
97df181a76 Generated stubs for Supporters module. 
Generated this by running: h2xs -AXc -n Supporters
 2015-12-06 17:20:14 -08:00