Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Correct off-by-one error in counter.

Browse source 
The counter should be incremented/decremented after testing its value,
not before.
This commit is contained in:
Bradley M. Kuhn 2015-12-14 17:20:17 -08:00
parent 45570a5db0
commit 2a374b957e
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Supporters/lib/Supporters.pm
View file

@ -411,9 +411,7 @@ sub _beginWork($) {
die "_beginWork: Mismatched begin_work/commit pair in API implementation" if ($NESTED_TRANSACTION_COUNTER < 0);
$NESTED_TRANSACTION_COUNTER++;
$self->dbh->begin_work() if ($NESTED_TRANSACTION_COUNTER == 1);
$self->dbh->begin_work() if ($NESTED_TRANSACTION_COUNTER++ == 1);
}
=item _commit()
@ -438,9 +436,7 @@ sub _commit($) {
die "_commit: Mismatched begin_work/commit pair in API implementation" if ($NESTED_TRANSACTION_COUNTER <= 0);
$NESTED_TRANSACTION_COUNTER--;
$self->dbh->commit() if ($NESTED_TRANSACTION_COUNTER == 0);
$self->dbh->commit() if ($NESTED_TRANSACTION_COUNTER-- == 0);
}
=back