Do not attempt to intuit renewal response here.

This code worked reasonable well when there was only one type of renewal
notice in play for a long period of time, but the point here is that we
can have many of them and this script should handle sending out the
different ones at different types.

We probably need an entirely separate script to intuit response.
This commit is contained in:
Bradley M. Kuhn 2016-12-02 14:37:38 -08:00
parent 13198815f3
commit 65070094ed

View file

@ -98,11 +98,6 @@ foreach my $supporterId (@supporterIds) {
if (defined $request->{fulfillDate}) { if (defined $request->{fulfillDate}) {
print STDERR "$supporterId lapsed on $expiresOn but recorded as renewed on $request->{fulfillDate}\n" print STDERR "$supporterId lapsed on $expiresOn but recorded as renewed on $request->{fulfillDate}\n"
if ( ($isLapsed or $lapsesInOneWeek) and $VERBOSE); if ( ($isLapsed or $lapsesInOneWeek) and $VERBOSE);
} elsif ( (not $isLapsed) and (not $lapsesInOneWeek)) {
$sp->fulfillRequest({donorId => $supporterId, requestType => $REQUEST_NAME,
who => $supporterId, how => "apparent renewal not noticed during import"});
print STDERR "$supporterId now expires on $expiresOn, recording rewnewal of type $REQUEST_NAME\n"
if $VERBOSE;
} else { } else {
print STDERR "$supporterId received this renewal notice already on $request->{requestDate}\n" print STDERR "$supporterId received this renewal notice already on $request->{requestDate}\n"
if $VERBOSE; if $VERBOSE;