From 65070094eda1a17da4b4a87b080fc3cdfa08eff8 Mon Sep 17 00:00:00 2001 From: "Bradley M. Kuhn" Date: Fri, 2 Dec 2016 14:37:38 -0800 Subject: [PATCH] Do not attempt to intuit renewal response here. This code worked reasonable well when there was only one type of renewal notice in play for a long period of time, but the point here is that we can have many of them and this script should handle sending out the different ones at different types. We probably need an entirely separate script to intuit response. --- scripts/send-renewal-notices.plx | 5 ----- 1 file changed, 5 deletions(-) diff --git a/scripts/send-renewal-notices.plx b/scripts/send-renewal-notices.plx index acab492..c3d5dc8 100644 --- a/scripts/send-renewal-notices.plx +++ b/scripts/send-renewal-notices.plx @@ -98,11 +98,6 @@ foreach my $supporterId (@supporterIds) { if (defined $request->{fulfillDate}) { print STDERR "$supporterId lapsed on $expiresOn but recorded as renewed on $request->{fulfillDate}\n" if ( ($isLapsed or $lapsesInOneWeek) and $VERBOSE); - } elsif ( (not $isLapsed) and (not $lapsesInOneWeek)) { - $sp->fulfillRequest({donorId => $supporterId, requestType => $REQUEST_NAME, - who => $supporterId, how => "apparent renewal not noticed during import"}); - print STDERR "$supporterId now expires on $expiresOn, recording rewnewal of type $REQUEST_NAME\n" - if $VERBOSE; } else { print STDERR "$supporterId received this renewal notice already on $request->{requestDate}\n" if $VERBOSE;