Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bug in tests found with transaction ref counting

Browse source 
Now that we are properly nesting transactions, this test is shown to be
incorrect.  Namely, it is indeed correct that the entire add should fail
when we've given something invalid: we don't want to add the requestType
if it wasn't already there if the parameter to add
addRequestConfigurations was invalid.
This commit is contained in:
Bradley M. Kuhn 2015-12-14 17:25:02 -08:00
parent 2a374b957e
commit 2950067c63
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Supporters/t/Supporters.t
View file

@ -186,8 +186,7 @@ my $tShirt0Data;
dies_ok { $sp->addRequestConfigurations('t-shirt-0', [ @sizeList, 'Men2XL']) }
"addRequestConfigurations: dies with duplicate items on configuration list.";
is_deeply({ $tShirt0RequestTypeId => {} },
$sp->getRequestConfigurations('t-shirt-0'),
is_deeply($sp->getRequestConfigurations('t-shirt-0'), undef,
"addRequestConfigurations/getRequestConfigurations: add fails with duplicate in configuration list");
lives_ok { $tShirt0Data = $sp->addRequestConfigurations('t-shirt-0', \@sizeList) }