Bradley M. Kuhn
4775799a99
Fix evaluation of ticket traffic to find right mentor.
...
The regex /^\s*([^:]+)\s*:\s*(.+)$/ is very overzealous, so use it last; find
all the other stuff we want first.
2019-04-07 21:26:19 -07:00
Bradley M. Kuhn
6ed5c75d85
Improve parsing of feedback.
2019-04-07 20:58:03 -07:00
Bradley M. Kuhn
d352fc5322
Improve output.
2019-04-07 20:57:52 -07:00
Bradley M. Kuhn
2b06c9f8bd
Correct amount of final payment.
2019-04-07 20:57:19 -07:00
Bradley M. Kuhn
5868b7c22f
Second payment amount changed in 2018-12 round.
2019-02-28 16:42:15 -08:00
Bradley M. Kuhn
9650769fee
Correct approvalTag setting for payments > 1
...
This implementation was simply incomplete in an earlier commit.
2019-02-28 16:41:16 -08:00
Bradley M. Kuhn
f1ed2eb991
Remove check to see if payment-N-approved set.
...
The Python script save-feedback.py now sets payment-N-approved, so this
script will run against tickets that are in needs-project-ok state and
payment-N-approved is set (for now, anyway).
2019-02-28 16:36:32 -08:00
Bradley M. Kuhn
e5bf1e9f90
Approvals no longer in files, but in the ticket comments.
...
This script was originally written to handle the approval data appearing in
files in a directory rather than the ticket traffic itself. This change
reworks that so that the script is always processing a group of tickets, and
searches for payment approval in the ticket traffic itself.
Note that this change is not yet secure, as the interns, if they know format,
could "approve themselves". The "security" comes from the script before (or
a by hand action with someone with RT access to set the completed-internship
field to 'payment-N-approved'.
2019-02-28 16:22:07 -08:00
Bradley M. Kuhn
6a659c102c
Various improvements made and not properly recorded.
...
I made various improvements quickly while processing payment 1 in 2018-12 and
this is the result. I didn't commit incrementally, but I do now see that I
added the support for activating the travel ticket and some error message
cleanup.
2019-02-28 14:40:09 -08:00
Bradley M. Kuhn
bf631e8259
Various changes to support Payment 1
...
My initial drafting of this script could not support Payment 1 properly, as I
started the script after Payment 1 in 2018-05 round was already done.
These changes, while not yet fully tested, probably should work to handle
Payment 1 tickets.
2019-01-14 09:26:21 -08:00
Bradley M. Kuhn
b301b2a86e
Improve payment output prep.
2018-09-22 17:30:44 -07:00
Bradley M. Kuhn
9145aec8c5
Correct link command.
2018-09-22 17:30:25 -07:00
Bradley M. Kuhn
c385cda4e4
Find payment details in ticket traffic from previous.
2018-09-22 17:29:44 -07:00
Bradley M. Kuhn
77f47bb9e1
Correct search terms function call.
2018-09-22 17:28:45 -07:00
Bradley M. Kuhn
afb3bbc340
Handle activated travel reimbursement tickets properly.
...
Travel reimbursement tickets might already be activated. We track activation
by leaving them to "dependson" the main travel ticket, and hav them only
refersto relationship once activated.
In cases where the dependson link does not exist, then we should send notice
upon failure when rejecting the ticket.
2018-09-12 15:57:53 -07:00
Bradley M. Kuhn
c3a368d29f
Ensure payment number is in ledger entry.
2018-09-12 15:57:44 -07:00
Bradley M. Kuhn
d6375aefd6
Fix verbose message and link setup.
2018-08-07 10:29:25 -07:00
Bradley M. Kuhn
608477135d
Adapt function to take round as an argument.
2018-08-05 19:28:36 -07:00
Bradley M. Kuhn
5d074729bd
FindReimbursementTicketFromList: move to rt-helper.pl
2018-08-05 19:27:11 -07:00
Bradley M. Kuhn
38f7b0cedc
Rework GetLinksForTicket, returns hash now
...
Include the Hash Id.
2018-08-05 19:15:51 -07:00
Bradley M. Kuhn
9867531a53
Make $round an argument to this sub.
...
Also, add $RT_CMD as an "our" variable.
2018-07-25 14:33:00 -07:00
Bradley M. Kuhn
7e52b5922b
Move PaymentDateByTicket to helper file.
2018-07-25 14:02:12 -07:00
Bradley M. Kuhn
0263c49c77
Move two functions to helper file.
2018-07-25 13:58:44 -07:00
Bradley M. Kuhn
34e00ca5f0
Create rt-helper.pl and move one function to it.
...
Move function to rt-helper.pl that might be used in other Perl scripts.
2018-07-25 13:57:02 -07:00
Bradley M. Kuhn
052d32fc5e
Add Travel notice ticket link, and fix RT commands.
2018-07-25 09:40:19 -07:00
Bradley M. Kuhn
5697b6beee
Add --round CLI argument; use that round for search criterion.
2018-07-22 19:25:49 -07:00
Bradley M. Kuhn
8aa05bff6d
Allow FIXME_INVOICE_DATE in document templates.
2018-07-22 19:25:42 -07:00
Bradley M. Kuhn
9cb57fe776
Complete script, improving error messages.
2018-07-22 18:49:06 -07:00
Bradley M. Kuhn
421dd769cb
Match better what is typical in the ticket subject
2018-07-22 18:05:23 -07:00
Bradley M. Kuhn
5c28767692
Remove unnecessary my
2018-07-22 16:36:07 -07:00
Bradley M. Kuhn
c0e328dccf
Add files for correspondence.
2018-07-22 16:35:55 -07:00
Bradley M. Kuhn
48ec393a01
Support lookup of reimbursement ticket
2018-07-22 16:35:35 -07:00
Bradley M. Kuhn
dcbf4bac2c
autodie on everything.
2018-07-22 16:02:13 -07:00
Bradley M. Kuhn
5936b5eec5
Improve output.
2018-07-22 16:02:07 -07:00
Bradley M. Kuhn
ace578089c
count old interns.
2018-07-22 15:31:18 -07:00
Bradley M. Kuhn
467522f331
Add pay date to error output.
2018-07-22 15:22:25 -07:00
Bradley M. Kuhn
f00819a174
Correct tax ticket processing.
2018-07-22 15:22:16 -07:00
Bradley M. Kuhn
2598a6f739
Additional issues with CF matching.
2018-07-22 15:21:59 -07:00
Bradley M. Kuhn
54cd914e47
LedgerTagFromTicket: handle that CF line might be first
...
The 'CF.{ledger-tags}: ' portion appears on the first line of output, so that
must be handled.
2018-07-22 15:13:03 -07:00
Bradley M. Kuhn
def7498189
newline should be on output.
2018-07-22 15:09:36 -07:00
Bradley M. Kuhn
eb52743036
Fix Regex.
2018-07-22 15:09:13 -07:00
Bradley M. Kuhn
cdf9526b3d
More processing work.
2018-07-22 15:08:59 -07:00
Bradley M. Kuhn
cebb1d813b
Move Entity lookup until after ticket is found.
2018-07-22 15:08:45 -07:00
Bradley M. Kuhn
cb49fb5c3e
Add command line option.
2018-07-22 15:08:31 -07:00
Bradley M. Kuhn
fc1c35c25c
Skip even if they did not pass.
2018-07-22 14:35:32 -07:00
Bradley M. Kuhn
0170039053
Add lines of #'s between functions.
2018-07-22 14:35:20 -07:00
Bradley M. Kuhn
0f0b60eada
Lookup previous payment and verify all is good.
2018-07-22 14:34:04 -07:00
Bradley M. Kuhn
9b7858843b
Add Entity lookup.
2018-07-22 14:33:02 -07:00
Bradley M. Kuhn
81b6fcefc1
Don't die on any failure; just move on to next file.
...
I'm going to leave the files as is if I can't really validly process them at
all, so the indicator that I finished the operation is renaming the file.
2018-07-15 09:07:54 -07:00
Bradley M. Kuhn
b48b6b3945
A few more ticket lookup subs.
2018-07-15 09:05:58 -07:00