From 77b603a1dd9180b371de8849132ef649abde1db5 Mon Sep 17 00:00:00 2001
From: Ben Sturmfels <ben@sturm.com.au>
Date: Fri, 23 Feb 2024 10:16:50 +1100
Subject: [PATCH] Confirm my questions for Rosanne

---
 TODO.md        |  4 ----
 src/import.clj | 10 +++++-----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/TODO.md b/TODO.md
index da19370..7bf01f7 100644
--- a/TODO.md
+++ b/TODO.md
@@ -3,7 +3,3 @@
 * Validation/error handling on CLI arguments - required options like csv, date, period
 * Potentially move employee-name->entity-tag into config
 * Potentially move cat->payroll-type into config
-* Confirm it's "Withholding" in individual taxes and "Liability" in employer taxes
-* Confirm extra NY-only insurance/asset postings in individual taxes
-* Confirm lack of :Tax: in employer taxes eg. "US:Medicare", not "US:Tax:Medicare" as in individual taxes
-* Confirm lack of :memo for Karen
diff --git a/src/import.clj b/src/import.clj
index d72f1de..5de9873 100644
--- a/src/import.clj
+++ b/src/import.clj
@@ -158,9 +158,8 @@
   (for [[name records] (group-by :name data)]
     (let [retirement-lines (filter #(= (:type %) "Retirement") records)
           witholding-lines (filter #(= (:type %) "Withholding") records)
-          ;; TODO: We seem to add these extra insurance/asset postings for
-          ;; Karen (NY) only, but not for say Pono/Sage/Bradley (OR). Confirm
-          ;; with Rosanne.
+          ;; We add these extra disability insurance/asset postings for NY only
+          ;; as discussed in beancount/doc/Payroll.md.
           insurance-lines (filter #(and (= (:type %) "Withholding")
                                         (str/starts-with? (:category %) "NY Disability")) records)
           total-retirement (->> retirement-lines
@@ -222,7 +221,8 @@
                              {:account "Expenses:Payroll:Tax"
                               :amount amount
                               :currency "USD"
-                              ;; TODO: Check lack of ":Tax:" with Rosanne.
+                              ;; Use eg. "US:Medicare", not "US:Tax:Medicare" as
+                              ;; in individual-taxes as confirmed by Rosanne.
                               :meta (assoc-project
                                      name
                                      {:entity name
@@ -237,7 +237,7 @@
                              :meta (assoc-project
                                     name
                                     {:entity (first (str/split category #" "))
-                                     :memo name
+                                     :memo name  ; distinguishes multiple employees in one state
                                      :payroll-type (str "US:" (cat->payroll-type category))})})
         total-unemploy (->> unemploy-postings (map :amount) (reduce +))
         asset-postings [{:account "Assets:FR:Check2721"