Orlando Del Aguila
4a18e32160
dev: add pry-byebug gem and move rack-timeout to production group
2019-08-09 13:08:57 -05:00
Orlando Del Aguila
9907a0dc99
dev: add gem standard
2019-08-09 11:49:54 -05:00
Luis Castro
1740511f2a
Merge pull request #24 from debtcollective/chore/debug-pry
...
Chore/debug pry
2019-08-09 16:24:03 +02:00
Luis Castro
79561913c7
docs(known_issues): add better headings and explicit answers
2019-08-08 14:59:10 +02:00
Luis Castro
f6d6fec936
docs(known_issues): change the language of explanation to 3rd person
2019-08-08 14:54:55 +02:00
Eric Schultz
49dda8037c
Merge pull request #212 from houdiniproject/extra_documentation
...
Add some documentation to the Mailchimp code
2019-08-07 13:39:49 -05:00
Eric Schultz
55b4ed0ff2
Add some documentation to the Mailchimp code
2019-08-07 13:15:47 -05:00
Luis Castro
97506ec3ab
docs(known_issues): add a list of steps to fix pry and byebug on a local machine
2019-08-07 10:40:51 +02:00
Luis Castro
9f39a17e29
docs(readme): remove rails 3.2 explanation
2019-08-07 10:27:54 +02:00
Orlando Del Aguila
e3a825103f
Merge pull request #17 from debtcollective/upgrade-and-organize-gems
...
Upgrade and organize gems
2019-08-05 13:00:40 -05:00
Luis Castro
5f40284b77
chore(gems): add byebug for better debugging
2019-08-05 15:23:29 +02:00
Luis Castro
69f780c3bf
chore: add libsass helpers to development env
2019-08-05 12:44:01 +02:00
Luis Castro
8258012ae8
chore: add pessimistic operator to all gems
...
Using the pessimistic operator in combination with consistent Semantic versioning by gem authors, we can theoretically achieve better stability in our dependencies.
2019-08-05 12:42:43 +02:00
Luis Castro
ff428870fb
chore: rename editable.css file and remove erb extension
2019-08-05 12:40:32 +02:00
Luis Castro
23603f0b1c
Merge pull request #14 from debtcollective/rails_v5
...
Upgrade to Rails v5.2.3
2019-08-02 19:52:50 +02:00
Orlando Del Aguila
9b753f9c6a
dev: add .ruby-gemset and fix dependencies issues
2019-08-02 12:49:24 -05:00
Luis Castro
deae69bce8
chore(shared_user_ctx): rename method for clarity
2019-08-02 19:19:56 +02:00
Luis Castro
b65b88b292
test(static_controller): fix inconsistency with Settings merge
2019-08-02 19:07:31 +02:00
Luis Castro
c21ddbba06
test(views): add arg for views without json format
2019-08-02 19:07:31 +02:00
Luis Castro
fd564be0bc
fix(test_uploader): remove frozen literal from test file
2019-08-02 19:07:31 +02:00
Luis Castro
096a6a27a1
test(payouts): add matching expectaions to db timestamp values
2019-08-02 19:07:31 +02:00
Luis Castro
5fe98ab464
test(timespan): fix inconsistency between expectation and actual output
...
* Also added timecop to spec to avoid future breaks.
2019-08-02 19:07:31 +02:00
Luis Castro
0a9b944526
fix(timespan): add correct calls to units from argument error
2019-08-02 19:07:30 +02:00
Luis Castro
3965ba59f9
feat(timespan): add new syntax for declaring constants in a Struct
2019-08-02 19:07:30 +02:00
Luis Castro
2552e831b3
chore(rspec): supress warnings on false positives
2019-08-02 19:07:30 +02:00
Luis Castro
aacd4af6c0
test(methods): add methods to without json response config
2019-08-02 19:07:30 +02:00
Luis Castro
529745bf22
test(button): remove from json views
2019-08-02 19:07:30 +02:00
Luis Castro
2c12b5864b
test(edit): fix edit actions controller expect to html render method
2019-08-02 19:07:30 +02:00
Luis Castro
f0fd393be4
style(format): run rubocop format autocorrect
2019-08-02 19:07:29 +02:00
Luis Castro
04a5eb039f
feat(pg_type_map): add validation for Qx to run if database exists
2019-08-02 19:07:29 +02:00
Luis Castro
da68bca689
docs(getting_started): add known bug for Qx gem at rake db setup
2019-08-02 19:07:29 +02:00
Luis Castro
7c1f78e7d6
docs(getting_started): add newest version of ruby
2019-08-02 19:07:28 +02:00
Luis Castro
1c28460ad7
feat(api): use active support reloader instead of callback
2019-08-02 19:07:28 +02:00
Luis Castro
cf5792d4e5
feat(gems): update Gemfile
2019-08-02 19:07:28 +02:00
Luis Castro
28a0793377
feat(campaigns): return expected api response
2019-08-02 19:07:28 +02:00
Luis Castro
df29d446ae
chore(models): comment out attr_accessible
...
Needs to be changed to strong params in controllers of each model.
2019-08-02 19:07:28 +02:00
Luis Castro
84f8a583ba
test(shared_user_ctx): add conditional specs for types of methods
2019-08-02 19:07:28 +02:00
Luis Castro
9f6ea91224
fix(direct_debit_detail): use class_name string value
2019-08-02 19:07:27 +02:00
Luis Castro
eb7c11d849
chore(gems): update rails and ruby version to latest
2019-08-02 19:07:27 +02:00
Luis Castro
d153de8d1f
fix(dependency): Remove require dependency for timespan constants
2019-08-02 19:07:27 +02:00
Luis Castro
33862bab25
test(support): fix any_instance deprecation warning
...
Changed from the old syntax to the new allow_any_instance_of according to the documentation.
https://www.rubydoc.info/github/rspec/rspec-mocks/RSpec/Mocks/ExampleMethods%3aallow_any_instance_of
2019-08-02 19:07:27 +02:00
Luis Castro
a20bd477ce
fix(static_controller): return body nil when 500
...
Fix deprecation warning from nothing.
2019-08-02 19:07:27 +02:00
Luis Castro
22bf0713f9
fix(campaign): add explicit source for payments relation
2019-08-02 19:07:27 +02:00
Luis Castro
4992253540
fix(constants): explicit require for constants
2019-08-02 19:07:26 +02:00
Luis Castro
812d546080
fix(app): fixnum is deprecated
...
Use Integer, since Fixnum and Bigint now belong to the same class in Ruby 2.4+
2019-08-02 19:07:26 +02:00
Luis Castro
e08d7836c6
test(nonprofit): fix xhr deprecation warnings
...
`xhr` and `xml_http_request` are deprecated, changed to new syntax
2019-08-02 19:07:26 +02:00
Luis Castro
d4f6e2d91d
test(donation_context): fix any_instance deprecation warning
...
Changed from the old syntax to the new allow_any_instance_of according to the documentation.
https://www.rubydoc.info/github/rspec/rspec-mocks/RSpec/Mocks/ExampleMethods%3aallow_any_instance_of
2019-08-02 19:07:26 +02:00
Luis Castro
fb638f0c26
test(shared_user_context): fix positional args warning
...
Using positional arguments in functional tests has been deprecated
2019-08-02 19:07:26 +02:00
Luis Castro
57125774ef
test(params): fix HttpPositionalArguments
...
Automatic run with `bundle exec rubocop --rails --only HttpPositionalArguments --auto-correct`
2019-08-02 19:07:26 +02:00
Luis Castro
c3c1311e2f
test(shared_user_context): move to ActionDistpach
...
From ActionController::TestResponse, to use the new IntegrationTest from rails 5.
2019-08-02 19:07:25 +02:00
