From f44a2129884dc113354f63e174d8d92a8af39a0c Mon Sep 17 00:00:00 2001 From: Eric Date: Fri, 24 Jul 2020 18:44:10 -0500 Subject: [PATCH] Set node to 13.14 becuase that includes full ICU --- .github/workflows/full_build.yml | 16 ++++++++-------- .nvmrc | 2 +- README.md | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/full_build.yml b/.github/workflows/full_build.yml index 8a180059..a46163f4 100644 --- a/.github/workflows/full_build.yml +++ b/.github/workflows/full_build.yml @@ -6,7 +6,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12] + node: [13.14] ruby: [2.6.6] steps: - uses: actions/checkout@v2 @@ -32,7 +32,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12] + node: [13.14] ruby: [2.6.6] steps: - uses: actions/checkout@v2 @@ -53,7 +53,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12] + node: [13.14] ruby: [2.6.6] needs: ['install_gems'] steps: @@ -82,7 +82,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12] + node: [13.14] ruby: [2.6.6] needs: ['install_gems', 'install_yarn'] steps: @@ -121,7 +121,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12] + node: [13.14] steps: - uses: actions/checkout@v2 - name: Setup Node.js environment @@ -140,7 +140,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12] + node: [13.14] needs: ['install_yarn'] steps: - uses: actions/checkout@v2 @@ -162,7 +162,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12] + node: [13.14] ruby: [2.6.6] steps: - uses: actions/checkout@v2 @@ -207,7 +207,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12] + node: [13.14] ruby: [2.6.6] steps: - uses: actions/checkout@v2 diff --git a/.nvmrc b/.nvmrc index 63c13a93..765200a6 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1,2 +1,2 @@ -12.0 +13.14 diff --git a/README.md b/README.md index c3430454..100a07ca 100644 --- a/README.md +++ b/README.md @@ -57,7 +57,7 @@ which make development much easier. These include: * PostgreSQL 10 or 11 -* NodeJS 12 LTS +* NodeJS 13 (we require 13 or higher because we want the full internationalization built-in) * Ruby 2.6.6 (NOTE: the default of Ruby 2.7.1 in Debian should function but you will receive a ton of deprecation warnings from Ruby) @@ -82,7 +82,7 @@ You'll want to run the next commands as root or via sudo (for Ubuntu 18.04 users ```bash apt update apt install curl -yy -curl -sL https://deb.nodesource.com/setup_12.x | bash - +curl -sL https://deb.nodesource.com/setup_13.x | bash - curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list apt update