From 82dbe471bd70d0ccf92669e07c7e9e762fcd3e33 Mon Sep 17 00:00:00 2001 From: Eric Schultz Date: Thu, 16 Aug 2018 14:33:36 -0500 Subject: [PATCH] Correct a bug where we get all params in the nonprofit --- app/api/houdini/v1/nonprofit.rb | 5 +++-- spec/api/houdini/nonprofit_spec.rb | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/api/houdini/v1/nonprofit.rb b/app/api/houdini/v1/nonprofit.rb index 669a7bbe..e01bc7cc 100644 --- a/app/api/houdini/v1/nonprofit.rb +++ b/app/api/houdini/v1/nonprofit.rb @@ -54,11 +54,12 @@ class Houdini::V1::Nonprofit < Houdini::V1::BaseAPI end post do + declared_params = declared(params) np = nil u = nil Qx.transaction do begin - np = Nonprofit.new(OnboardAccounts.set_nonprofit_defaults(params[:nonprofit])) + np = Nonprofit.new(OnboardAccounts.set_nonprofit_defaults(declared_params[:nonprofit])) begin np.save! @@ -80,7 +81,7 @@ class Houdini::V1::Nonprofit < Houdini::V1::BaseAPI end end - u = User.new(params[:user]) + u = User.new(declared_params[:user]) u.save! role = u.roles.build(host: np, name: 'nonprofit_admin') diff --git a/spec/api/houdini/nonprofit_spec.rb b/spec/api/houdini/nonprofit_spec.rb index 56ef886b..f3e51aec 100644 --- a/spec/api/houdini/nonprofit_spec.rb +++ b/spec/api/houdini/nonprofit_spec.rb @@ -130,7 +130,7 @@ describe Houdini::V1::Nonprofit, :type => :controller do it "succeeds" do force_create(:nonprofit, slug: "n", state_code_slug: "wi", city_slug: "appleton") input = { - nonprofit: {name: "n", state_code: "WI", city: "appleton", zip_code: 54915, url: 'www.cs.c'}, + nonprofit: {name: "n", state_code: "WI", city: "appleton", zip_code: 54915, url: 'www.cs.c', website: 'www.cs.c'}, user: {name: "Name", email: "em@em.com", password: "12345678", password_confirmation: "12345678"} }