[ledgercli] Do not remove the old transaction on invalid update

accounting/storage/ledgercli.py

@@ -442,7 +442,11 @@ class Ledger(Storage):
 
         self.delete_transaction(transaction.id)
 
-        self.add_transaction(transaction)
+        try:
+            self.add_transaction(transaction)
+        except AccountingException as exc:
+            self.add_transaction(old_transaction)
+            raise exc
 
         _log.info('Updated transaction %s', transaction.id)
         _log.debug('Updated transaction from: %s to: %s', old_transaction,

accounting/tests/test_transactions.py

@@ -336,5 +336,20 @@ class TransactionTestCase(unittest.TestCase):
                     'Something about this transaction\'s postings is' \
                     ' unexpected'
 
+    def test_invalid_update_transaction_does_not_remove_existing(self):
+        transaction = self._add_simple_transaction()
+        old_transaction = copy.deepcopy(transaction)
+
+        transaction.postings[0].amount.amount = '9001.01'
+
+        response = self._post_json('/transaction/' + transaction.id,
+                                   {'transaction': transaction}, 400)
+
+        self.assertEqual(response['error']['type'], 'LedgerNotBalanced')
+
+        response = self._get_json('/transaction/' + transaction.id)
+
+        self.assertEqual(response['transaction'], old_transaction)
+
 if __name__ == '__main__':
     unittest.main()