c712105bed
The main impetus of this change is to rename accounts that were outside Beancount's accepted five root accounts, to move them into that structure. This includes: Accrued:*Payable: → Liabilities:Payable:* Accrued:*Receivable: → Assets:Receivable:* UneanedIncome:* → Liabilities:UnearnedIncome:* Note the last change did inspire in a change to our validation rules. We no longer require income-type on unearned income, because it's no longer considered income at all. Once it's earned and converted to an Income account, that has an income-type of course. This did inspire another rename that was not required, but provided more consistency with the other account names above: Assets:Prepaid* → Assets:Prepaid:* Where applicable, I have generally extended tests to make sure one of each of the five account types is tested. (This mostly meant adding an Equity account to the tests.) I also added tests for key parts of the hierarchy, like Assets:Receivable and Liabilities:Payable, where applicable. As part of this change, Account.is_real_asset() got renamed to Account.is_cash_equivalent(), to better self-document its purpose.
156 lines
5.1 KiB
Python
156 lines
5.1 KiB
Python
"""Test handling of project metadata"""
|
|
# Copyright © 2020 Brett Smith
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU Affero General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Affero General Public License
|
|
# along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from . import testutil
|
|
|
|
from conservancy_beancount import errors as errormod
|
|
from conservancy_beancount.plugin import meta_project
|
|
|
|
VALID_VALUES = {
|
|
'Conservancy': 'Conservancy',
|
|
'Alpha': 'Alpha',
|
|
'Bravo': 'Bravo',
|
|
'Charles': 'Charlie',
|
|
'Chuck': 'Charlie',
|
|
}
|
|
|
|
INVALID_VALUES = {
|
|
'Alhpa',
|
|
'Yankee',
|
|
'',
|
|
}
|
|
|
|
TEST_KEY = 'project'
|
|
DEFAULT_VALUE = 'Conservancy'
|
|
|
|
@pytest.fixture(scope='module')
|
|
def hook():
|
|
config = testutil.TestConfig(repo_path='repository')
|
|
return meta_project.MetaProject(config)
|
|
|
|
@pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())
|
|
def test_valid_values_on_postings(hook, src_value, set_value):
|
|
txn = testutil.Transaction(postings=[
|
|
('Assets:Cash', -25),
|
|
('Expenses:General', 25, {TEST_KEY: src_value}),
|
|
])
|
|
errors = list(hook.run(txn))
|
|
assert not errors
|
|
testutil.check_post_meta(txn, None, {TEST_KEY: set_value})
|
|
|
|
@pytest.mark.parametrize('src_value', INVALID_VALUES)
|
|
def test_invalid_values_on_postings(hook, src_value):
|
|
txn = testutil.Transaction(postings=[
|
|
('Assets:Cash', -25),
|
|
('Expenses:General', 25, {TEST_KEY: src_value}),
|
|
])
|
|
errors = list(hook.run(txn))
|
|
assert errors
|
|
testutil.check_post_meta(txn, None, {TEST_KEY: src_value})
|
|
|
|
@pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())
|
|
def test_valid_values_on_transactions(hook, src_value, set_value):
|
|
txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[
|
|
('Assets:Cash', -25),
|
|
('Expenses:General', 25),
|
|
])
|
|
errors = list(hook.run(txn))
|
|
assert not errors
|
|
testutil.check_post_meta(txn, None, {TEST_KEY: set_value})
|
|
|
|
@pytest.mark.parametrize('src_value', INVALID_VALUES)
|
|
def test_invalid_values_on_transactions(hook, src_value):
|
|
txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[
|
|
('Assets:Cash', -25),
|
|
('Expenses:General', 25),
|
|
])
|
|
errors = list(hook.run(txn))
|
|
assert errors
|
|
testutil.check_post_meta(txn, None, None)
|
|
|
|
@pytest.mark.parametrize('account,required', [
|
|
('Assets:Cash', False),
|
|
('Assets:Receivable:Accounts', True),
|
|
('Assets:Receivable:Loans', True),
|
|
('Equity:OpeningBalance', False),
|
|
('Expenses:General', True),
|
|
('Income:Donations', True),
|
|
('Liabilities:CreditCard', False),
|
|
('Liabilities:Payable:Accounts', True),
|
|
# We do want a "project" for Lia:Pay:Vacation but it has a default value
|
|
('Liabilities:Payable:Vacation', False),
|
|
('Liabilities:UnearnedIncome:Donations', True),
|
|
])
|
|
def test_which_accounts_required_on(hook, account, required):
|
|
txn = testutil.Transaction(postings=[
|
|
('Assets:Checking', 25),
|
|
(account, 25),
|
|
])
|
|
errors = list(hook.run(txn))
|
|
assert required == any(errors)
|
|
|
|
@pytest.mark.parametrize('account', [
|
|
'Expenses:Payroll:Salary',
|
|
'Expenses:Payroll:Tax',
|
|
'Liabilities:Payable:Vacation',
|
|
])
|
|
def test_default_values(hook, account):
|
|
txn = testutil.Transaction(postings=[
|
|
('Assets:Checking', -25),
|
|
(account, 25),
|
|
])
|
|
errors = list(hook.run(txn))
|
|
assert not errors
|
|
testutil.check_post_meta(txn, None, {TEST_KEY: DEFAULT_VALUE})
|
|
|
|
@pytest.mark.parametrize('date,required', [
|
|
(testutil.EXTREME_FUTURE_DATE, False),
|
|
(testutil.FUTURE_DATE, True),
|
|
(testutil.FY_START_DATE, True),
|
|
(testutil.FY_MID_DATE, True),
|
|
(testutil.PAST_DATE, None),
|
|
])
|
|
def test_default_value_set_in_date_range(hook, date, required):
|
|
txn = testutil.Transaction(date=date, postings=[
|
|
('Expenses:Payroll:Benefits', 25),
|
|
('Liabilities:Payable:Vacation', -25),
|
|
])
|
|
errors = list(hook.run(txn))
|
|
assert not errors
|
|
expect_meta = {TEST_KEY: DEFAULT_VALUE} if required else None
|
|
testutil.check_post_meta(txn, expect_meta, expect_meta)
|
|
|
|
@pytest.mark.parametrize('repo_path', [
|
|
None,
|
|
'..',
|
|
])
|
|
def test_missing_project_data(repo_path):
|
|
config = testutil.TestConfig(repo_path=repo_path)
|
|
with pytest.raises(errormod.ConfigurationError):
|
|
meta_project.MetaProject(config)
|
|
|
|
@pytest.mark.parametrize('repo_path_s,data_path_s', [
|
|
('repository', 'Projects/project-list.yml'),
|
|
('..', 'LICENSE.txt'),
|
|
])
|
|
def test_invalid_project_data(repo_path_s, data_path_s):
|
|
config = testutil.TestConfig(repo_path=repo_path_s)
|
|
with pytest.raises(errormod.ConfigurationError):
|
|
meta_project.MetaProject(config, Path(data_path_s))
|