meta_receipt: Not required on interest income. RT#11695.

This commit is contained in:
Brett Smith 2020-06-22 16:33:43 -04:00
parent 887102ea92
commit f9411e0ffe
3 changed files with 31 additions and 1 deletions

View file

@ -36,6 +36,18 @@ class MetaReceipt(core._RequireLinksPostingMetadataHook):
def __init__(self, config: configmod.Config) -> None: def __init__(self, config: configmod.Config) -> None:
self.payment_threshold = abs(config.payment_threshold()) self.payment_threshold = abs(config.payment_threshold())
def _run_on_txn(self, txn: Transaction) -> bool:
if not super()._run_on_txn(txn):
return False
elif (all(post.account.startswith('Assets:') for post in txn.postings
if post.units.number and post.units.number > 0)
and all(post.account == 'Income:Interest' for post in txn.postings
if post.units.number and post.units.number < 0)
):
return False
else:
return True
def _run_on_post(self, txn: Transaction, post: data.Posting) -> bool: def _run_on_post(self, txn: Transaction, post: data.Posting) -> bool:
return ( return (
(post.account.is_cash_equivalent() or post.account.is_credit_card()) (post.account.is_cash_equivalent() or post.account.is_credit_card())

View file

@ -5,7 +5,7 @@ from setuptools import setup
setup( setup(
name='conservancy_beancount', name='conservancy_beancount',
description="Plugin, library, and reports for reading Conservancy's books", description="Plugin, library, and reports for reading Conservancy's books",
version='1.3.0', version='1.3.1',
author='Software Freedom Conservancy', author='Software Freedom Conservancy',
author_email='info@sfconservancy.org', author_email='info@sfconservancy.org',
license='GNU AGPLv3+', license='GNU AGPLv3+',

View file

@ -344,6 +344,24 @@ def test_fallback_on_zero_amount_postings(hook, test_pair, other_acct, value):
]) ])
assert not list(hook.run(txn)) assert not list(hook.run(txn))
@pytest.mark.parametrize('test_acct', (
acct for acct in ACCOUNTS
if acct.name.startswith('Assets:')
and acct.required_types & PostType.CREDIT
))
def test_not_required_on_interest(hook, test_acct):
check(hook, test_acct, 'Income:Interest', None,
check_type=PostType.CREDIT)
@pytest.mark.parametrize('test_acct', (
acct for acct in ACCOUNTS
if acct.name.startswith('Assets:')
and acct.required_types & PostType.DEBIT
))
def test_required_on_reverse_interest(hook, test_acct):
check(hook, test_acct, 'Income:Interest', {test_acct.missing_message()},
check_type=PostType.DEBIT)
@pytest.mark.parametrize('test_acct,equity_acct', testutil.combine_values( @pytest.mark.parametrize('test_acct,equity_acct', testutil.combine_values(
ACCOUNTS, ACCOUNTS,
testutil.OPENING_EQUITY_ACCOUNTS, testutil.OPENING_EQUITY_ACCOUNTS,