NPO-Accounting/conservancy_beancount
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

meta_approval: Not required for chargebacks. RT#10978.

Browse source
This commit is contained in:
Brett Smith 2020-05-01 16:24:24 -04:00
parent 23e1ed7cee
commit e429a6c6fd
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
conservancy_beancount/plugin/meta_approval.py
View file

@ -44,4 +44,8 @@ class MetaApproval(core._RequireLinksPostingMetadataHook):
) )
def _run_on_post(self, txn: Transaction, post: data.Posting) -> bool: def _run_on_post(self, txn: Transaction, post: data.Posting) -> bool:
return post.account.is_cash_equivalent() and post.units.number < 0 return (
post.account.is_cash_equivalent()
and post.units.number < 0
and post.meta.get('tax-implication', '').title() != 'Chargeback'
)

10
tests/test_meta_approval.py
View file

@ -159,10 +159,14 @@ def test_approval_not_required_to_pay_credit_card(hook):
]) ])
assert not list(hook.run(txn)) assert not list(hook.run(txn))
def test_approval_not_required_for_asset_transfers(hook): @pytest.mark.parametrize('tax_implication,other_acct', [
('Bank-Transfer', 'Assets:Savings'),
('Chargeback', 'Income:Donations'),
])
def test_approval_not_required_for_asset_transfers(hook, tax_implication, other_acct):
txn = testutil.Transaction(postings=[ txn = testutil.Transaction(postings=[
('Assets:Checking', -250, {'tax-implication': 'Bank-Transfer'}), ('Assets:Checking', -250, {'tax-implication': tax_implication}),
('Assets:Savings', 250), (other_acct, 250),
]) ])
assert not list(hook.run(txn)) assert not list(hook.run(txn))