NPO-Accounting/conservancy_beancount
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

accrual: Outgoing report uses first rt-id as primary ticket number.

Browse source 
This makes it consistent with the reporting and our general rule
that the first link is primary.
This commit is contained in:
Brett Smith 2020-06-08 16:37:51 -04:00
parent e22e63dcca
commit 8dc6894ce7
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
conservancy_beancount/reports/accrual.py
View file

@ -508,7 +508,12 @@ class OutgoingReport(BaseReport):
self.rt_wrapper = rtutil.RT(rt_client) self.rt_wrapper = rtutil.RT(rt_client)
def _primary_rt_id(self, posts: AccrualPostings) -> rtutil.TicketAttachmentIds: def _primary_rt_id(self, posts: AccrualPostings) -> rtutil.TicketAttachmentIds:
rt_ids = posts.all_meta_links('rt-id') rt_ids: Set[str] = set()
for post in posts:
try:
rt_ids.add(post.meta.get_links('rt-id')[0])
except (IndexError, TypeError):
pass
rt_ids_count = len(rt_ids) rt_ids_count = len(rt_ids)
if rt_ids_count != 1: if rt_ids_count != 1:
raise ValueError(f"{rt_ids_count} rt-id links found") raise ValueError(f"{rt_ids_count} rt-id links found")

2
setup.py
View file

@ -5,7 +5,7 @@ from setuptools import setup
setup( setup(
name='conservancy_beancount', name='conservancy_beancount',
description="Plugin, library, and reports for reading Conservancy's books", description="Plugin, library, and reports for reading Conservancy's books",
version='1.1.3', version='1.1.4',
author='Software Freedom Conservancy', author='Software Freedom Conservancy',
author_email='info@sfconservancy.org', author_email='info@sfconservancy.org',
license='GNU AGPLv3+', license='GNU AGPLv3+',

2
tests/books/accruals.beancount
View file

@ -108,7 +108,7 @@
Liabilities:Payable:Accounts -60.00 USD Liabilities:Payable:Accounts -60.00 USD
2010-06-18 * "EuroGov" "European legal fees" 2010-06-18 * "EuroGov" "European legal fees"
rt-id: "rt:520" rt-id: "rt:520 rt:525"
invoice: "rt:520/5200" invoice: "rt:520/5200"
contract: "rt:520/5220" contract: "rt:520/5220"
Liabilities:Payable:Accounts -1,000 EUR {1.100 USD} Liabilities:Payable:Accounts -1,000 EUR {1.100 USD}