NPO-Accounting/conservancy_beancount
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

reports: ODS links default to using URL as link text.

Browse source
This commit is contained in:
Brett Smith 2020-06-12 16:42:54 -04:00
parent 44946a061d
commit 17c5468a7d
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
conservancy_beancount/reports/core.py
View file

@ -928,7 +928,7 @@ class BaseODS(BaseSpreadsheet[RT, ST], metaclass=abc.ABCMeta):
text = None text = None
cell.addElement(odf.text.P()) cell.addElement(odf.text.P())
cell.lastChild.addElement(odf.text.A( cell.lastChild.addElement(odf.text.A(
type='simple', href=href, text=text, type='simple', href=href, text=text or href,
)) ))
return cell return cell

4
tests/test_reports_spreadsheet.py
View file

@ -514,7 +514,7 @@ def test_ods_writer_multilink_singleton(ods_writer, cell_source, style_name):
href = cell_source href = cell_source
text = None text = None
anchor = get_child(cell, odf.text.A, type='simple', href=href) anchor = get_child(cell, odf.text.A, type='simple', href=href)
assert get_text(anchor) == (text or '') assert get_text(anchor) == (text or href)
def test_ods_writer_multilink_cell(ods_writer): def test_ods_writer_multilink_cell(ods_writer):
cell = ods_writer.multilink_cell(iter(LINK_CELL_DATA)) cell = ods_writer.multilink_cell(iter(LINK_CELL_DATA))
@ -528,7 +528,7 @@ def test_ods_writer_multilink_cell(ods_writer):
text = None text = None
assert child.getAttribute('type') == 'simple' assert child.getAttribute('type') == 'simple'
assert child.getAttribute('href') == href assert child.getAttribute('href') == href
assert get_text(child) == (text or '') assert get_text(child) == (text or href)
@pytest.mark.parametrize('cell_source,style_name', testutil.combine_values( @pytest.mark.parametrize('cell_source,style_name', testutil.combine_values(
STRING_CELL_DATA, STRING_CELL_DATA,