NPO-Accounting/conservancy_beancount
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rtutil: Fix crash when multiple RTLinkCaches race.

Browse source 
This was most likely to happen with multiple bean-checks running in
parallel: they would both see a new RT URL, fetch it, and try to
insert it into the cache. That's not a problem as long as they're
both inserting the same URL, so catch that exception.
This commit is contained in:
Brett Smith 2020-08-30 11:18:32 -04:00
parent dc2e2d200d
commit 0e52f11a58
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
conservancy_beancount/rtutil.py
View file

@ -171,10 +171,16 @@ class RTLinkCache(_LinkCache):
self._nourls.add(key) self._nourls.add(key)
else: else:
ticket_id, attachment_id = key ticket_id, attachment_id = key
self._db.execute( try:
'INSERT INTO RTLinkCache VALUES(?, ?, ?)', self._db.execute(
(ticket_id, attachment_id, value), 'INSERT INTO RTLinkCache VALUES(?, ?, ?)',
) (ticket_id, attachment_id, value),
)
except sqlite3.IntegrityError:
# Another instance might've inserted the URL before we did.
# That's fine as long as it's the same URL, which it should be.
if value != self.get(key):
raise
def __delitem__(self, key: TicketAttachmentIds) -> None: def __delitem__(self, key: TicketAttachmentIds) -> None:
raise NotImplementedError("RTLinkCache.__delitem__") raise NotImplementedError("RTLinkCache.__delitem__")