Summarize minor annoyances and wrap up.

This commit is contained in:
Bradley M. Kuhn 2014-11-07 10:06:21 -05:00
parent 33b39cda78
commit f17465ba61

View file

@ -694,32 +694,27 @@ The comparison steps we as follows:
\end{enumerate} \end{enumerate}
\end{enumerate} \end{enumerate}
\section{Minor Infractions} \section{Minor Annoyances}
As mentioned above, there were a few minor infractions. These made it slightly As discussed in detail above, there were a few minor annoyances, none of
difficult to complete the build and installation without additional context, but which were GPL violations. Rather, the annoyances briefly impeded the
did not make the build impossible to complete without more information, such as build and installation. However, the investigator, as a reasonably skilled
missing source code for kernel modules or depending on a specific cross-compiler build engineer for embedded devices, was able to complete the process with
but not mentioning which one or, better yet, including its source code, which the instructions provided.
are both more problematic infractions. These minor infractions were:
% FIXME: clarify seriousness of no install instructions; lack of clarity in To summarize, no GPL compliance issues were found, and the CCS release was
% which version to install could be more problematic one of the best ever reviewed by an investigator. However, the following
annoyances were discovered:
* Not mentioning how to extract the source tarball and then where to run the \begin{itemize}
"make" command. \item Failure to explain how to extract the source tarball and then where to run the
* Not mentioning how to install the kernel and root filesystem on the device; ``make'' command.
this is the biggest of these 3 issues but a bit less troublesome than it would \item Failure to explain how to install the kernel and root filesystem on the
otherwise have been since the web-based firmware update process is well-known. device; the user must assume the web UI must be used.
* Using pre-built toolchain binaries that don't work on all systems instead of
the ones that are built in a separate step, but not moved to the right place. \item Including pre-built toolchain binaries that don't work on all systems,
We were able to build corresponding toolchain binaries from source (though and failure to built toolchain binaries to the right location.
for a slightly different target) so this is not a severe toolchain violation \end{itemize}
of the type we normally find (where toolchain binaries are provided without
source). However, including instructions to use the built toolchain binaries
instead would be best, or alternatively specifying the distribution on which
the toolchain binaries must be run (to avoid being unable to run them as we
were).
\section{Lessons Learned} \section{Lessons Learned}