From 8c3ecd347abd9d7840c028cc5da953d9fb5df05a Mon Sep 17 00:00:00 2001
From: "Bradley M. Kuhn" <bkuhn@ebb.org>
Date: Wed, 3 Dec 2014 20:40:41 -0500
Subject: [PATCH] Return amount to id; add id for error span.

I actually think I want amount to be id rather than a class, now that I
figured out the proper selector to find them all.

Also, the $("span", input.parent()) was buggy if there were any other
span's other than error-related ones in the supporter-form-inputs div.

Finally, ditch that <small> stuff and simply place a font-size reduction
into the CSS for the form-error-show.
---
 www/conservancy/static/forms.css            |  1 +
 www/conservancy/static/supporter-page.js    |  6 +++---
 www/conservancy/static/supporter/index.html | 12 ++++++------
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/www/conservancy/static/forms.css b/www/conservancy/static/forms.css
index 4cca8365..c83935b7 100644
--- a/www/conservancy/static/forms.css
+++ b/www/conservancy/static/forms.css
@@ -25,6 +25,7 @@
 .form-error-show {
     color: red;
     margin-left: 10px;
+    font-size: 75%;
 }
 
 input.invalid, textarea.invalid {
diff --git a/www/conservancy/static/supporter-page.js b/www/conservancy/static/supporter-page.js
index 945ef68e..052c21f0 100644
--- a/www/conservancy/static/supporter-page.js
+++ b/www/conservancy/static/supporter-page.js
@@ -44,11 +44,11 @@ $(document).ready(function() {
             $("#no_shipping").val("0");
         }
     });
-    $('.amount').addClass("valid");
-    $('.amount').on('input', function() {
+    $('*#amount').addClass("valid");
+    $('*#amount').on('input', function() {
         var input=$(this);
         var value = input.val();
-        var errorElement=$("span", input.parent());
+        var errorElement=$("span#error", input.parent());
         var noCommaValue = value;
         noCommaValue = value.replace(/,/g, "");
         var re = /^((\d{1,3}(,?\d{3})*?(\.\d{0,2})?)|\d+(\.\d{0,2})?)$/;
diff --git a/www/conservancy/static/supporter/index.html b/www/conservancy/static/supporter/index.html
index b0edf600..d0d7b91a 100644
--- a/www/conservancy/static/supporter/index.html
+++ b/www/conservancy/static/supporter/index.html
@@ -141,9 +141,9 @@ internal policies</a> are published and available for scrutiny.</p>
             <input type="hidden" name="item_name" value="Conservancy Supporter, Annual" />
             <input id="no_shipping" type="hidden" name="no_shipping" value="0" />
   <label for="amount"><strong>Amount:</strong> $</label>
-  <input class="amount" type="text" name="amount" size="7" minimum="120" value="120" />
-  <span class="form-error"><small>$120 is a minimum for Conservancy
-  Supporters.  <a href="/donate">Donate smaller amounts here</a>.</small></span><br/>
+  <input id="amount" type="text" name="amount" size="7" minimum="120" value="120" />
+  <span id="error" class="form-error">$120 is a minimum for Conservancy
+  Supporters.  <a href="/donate">Donate smaller amounts here</a>.</span><br/>
 
                       <label for="wantGift"><strong>Do you want to receive a t-shirt? </strong></label>
                       <input type="hidden" name="on1" value="wantGift" />
@@ -208,9 +208,9 @@ internal policies</a> are published and available for scrutiny.</p>
             <input type="hidden" name="srt" value="0" />
             <input type="hidden" name="item_name" value="Conservancy Supporter, Monthly" />
   <label for="amount"><strong>Monthly Amount:</strong> $</label>
-  <input class="amount" type="text" name="a3" size="5" minimum="10" value="10" />
-  <span class="form-error"><small>$10/month is a minimum for Conservancy
-  Supporters.  <a href="/donate">Donate smaller amounts here</a>.</small></span><br/>
+  <input id="amount" type="text" name="a3" size="5" minimum="10" value="10" />
+  <span id="error" class="form-error">$10/month is a minimum for Conservancy
+  Supporters.  <a href="/donate">Donate smaller amounts here</a>.</span><br/>
                       <label for="wantGift"><strong>Do you want to receive a t-shirt? </strong></label>
                       <input type="hidden" name="on1" value="wantGift" />
                       <input type="radio" name="os1" value="Yes" />Yes