From 76b653ed8afb8bda19b4afe7ebffa7b8f9c14d55 Mon Sep 17 00:00:00 2001 From: Denver Gingerich Date: Fri, 17 Apr 2015 16:05:31 -0400 Subject: [PATCH] Lawsuit FAQ now uses ESXi 6.0 and add minor fixes. The main change here is that the lawsuit FAQ page now shows one how to verify that VMware combined Linux source code with their binary-only components using VMware's ESXi 6.0 rather than ESXi 5.5 Update 2. This required a couple minor path changes and updates to the memory addresses and SHA-1 checksums. The analysis steps otherwise remained the same. The FAQ is now more generic in its discussion of the ESXi versions that were originally analyzed, in order to avoid confusion with the analysis provided in the FAQ, which uses a newer version and reaches the same conclusion. Some minor, unrelated fixes were also added. These include: * add period at end of paragraphs where it was previously missing * convert ">" in 
 and  to ">" so the page is valid HTML
 * convert "&" in 
 to "&" so the page is valid HTML
 * add missing 's' to "truct pci_driver"
 * fix the "tg.c" filename - this should be "tg3.c"
---
 .../linux-compliance/vmware-lawsuit-faq.html  | 92 ++++++++++---------
 1 file changed, 47 insertions(+), 45 deletions(-)

diff --git a/www/conservancy/static/linux-compliance/vmware-lawsuit-faq.html b/www/conservancy/static/linux-compliance/vmware-lawsuit-faq.html
index 99761922..0da1f8a1 100644
--- a/www/conservancy/static/linux-compliance/vmware-lawsuit-faq.html
+++ b/www/conservancy/static/linux-compliance/vmware-lawsuit-faq.html
@@ -138,7 +138,7 @@
   component in ESXi that the lawsuit alleges violates the GPL?
 

     
The GPL violation at issue involves VMware's ESXi product.
-    Conservancy independently reviewed ESXi 5.5 and its incomplete
+    Conservancy independently reviewed ESXi and its incomplete
       CCS
     release as part of our GPL enforcement efforts described above.

 
@@ -202,12 +202,12 @@ Code, and for which (at least some) source code is provided.
        good, since the court documents discuss the specifics of alleged
          infringement on Hellwig's copyrights.

 
-       
However, Conservancy examined VMware's ESXi 5.5 product in detail
+       
However, Conservancy examined VMware's ESXi product in detail
        even before Hellwig's enforcement action began.  Below is one example
        among many where VMware's CCS was incomplete per GPLv2§2(c) and
        GPLv2§3(a).  (One can verify these results by
        downloading and installing the binary and source
-       packages for VMware's ESXi 5.5 Update 2.)  Note that this
+       packages for VMware's ESXi 6.0.)  Note that this
        example below is not necessarily regarding
        Hellwig's copyrights; VMware incorporated Linux code copyrighted by
        many others as well into their kernel.

@@ -216,7 +216,7 @@ Code, and for which (at least some) source code is provided.
        
Our example begins with examination of the file
            called vmkdrivers/src_92/vmklinux_92/vmware/linux_pci.c,
            which can be found in the “Open Source” release for
-           ESXi 5.5.0 Update 2 (5.5U2).  A small excerpt from that file, found in the
+           ESXi 6.0.  A small excerpt from that file, found in the
            function LinuxPCIDeviceRemoved(), reads as follows:

 
 
@@ -238,8 +238,8 @@ LinuxPCIDeviceRemoved(vmk_PCIDevice vmkDev)
       vmkDevName[0] = 0;
   }
 [...]
-VMKAPI_MODULE_CALL_VOID(pciDevExt->moduleID,
-                        linuxDev->driver->remove,
+VMKAPI_MODULE_CALL_VOID(pciDevExt->moduleID,
+                        linuxDev->driver->remove,
                         linuxDev);
 
        
 
@@ -247,8 +247,8 @@ VMKAPI_MODULE_CALL_VOID(pciDevExt->moduleID,
 
 
The function, vmk_PCIGetDeviceName() must be defined, with an
       implementation, for this code above to work, or even compile.
-      Inside BLD/build/HEADERS/vmkapi-current-all-public/vmkernel64/release/device/vmkapi_pci_incompat.h,
-      found in the vmkdrivers package of ESXi 5.5U2, shows a
+      Inside BLD/build/HEADERS/vmkapi-current-all-public/generic/release/hardware/vmkapi_pci_incompat.h,
+      found in the vmkdrivers package of ESXi 6.0, shows a
       function header definition for vmk_PCIGetDeviceName().
       However, the source of its implementation is not provided there or
       anywhere in the source release.

@@ -268,10 +268,10 @@ VMKAPI_MODULE_CALL_VOID(pciDevExt->moduleID,
 

 
 
-00000000000327ff R_X86_64_PC32     vmk_PCIGetDeviceName+0xfffffffffffffffc
-0000000000035318 R_X86_64_PC32     vmk_PCIGetDeviceName+0xfffffffffffffffc
-00000000000387e1 R_X86_64_PC32     vmk_PCIGetDeviceName+0xfffffffffffffffc
-000000000003cf40 R_X86_64_PC32     vmk_PCIGetDeviceName+0xfffffffffffffffc
+0000000000032db3 R_X86_64_PC32     vmk_PCIGetDeviceName+0xfffffffffffffffc
+00000000000333ea R_X86_64_PC32     vmk_PCIGetDeviceName+0xfffffffffffffffc
+0000000000036644 R_X86_64_PC32     vmk_PCIGetDeviceName+0xfffffffffffffffc
+000000000003986a R_X86_64_PC32     vmk_PCIGetDeviceName+0xfffffffffffffffc
 

 
 
The above two properties both suggest that the vmklinux_9
@@ -280,9 +280,9 @@ VMKAPI_MODULE_CALL_VOID(pciDevExt->moduleID,
  inside vmklinux_9 itself.

 
 
The definition can however be found in binary-only software provided in
-  ESXi 5.5U2 — specifically, inside a file named k.b00,
+  ESXi 6.0 — specifically, inside a file named k.b00,
   which is located in partition 5 on a disk where ESXi has been installed (or
-  in the ESXi 5.5U2 installer ISO image).  Running file
+  in the ESXi 6.0 installer ISO image).  Running file
   after gunzip on this file yields “ELF 64-bit LSB shared
   object”.  Meanwhile, file k.b00 reports “gzip
   compressed data, was ‘vmvisor64-vmkernel.stripped’”.
@@ -291,7 +291,7 @@ VMKAPI_MODULE_CALL_VOID(pciDevExt->moduleID,
   “SYMBOL TABLE” section:

 
 
-000041800036a408 g     F .text  0000000000000137 vmk_PCIGetDeviceName
+000041800033193c g     F .text  000000000000012e vmk_PCIGetDeviceName
 

 
 
… which indicated these binary file contains the function body
@@ -317,25 +317,27 @@ for  vmk_PCIGetDeviceName.

 
   
 struct pci_dev {
-[...]
-       struct pci_driver *driver;      /* which driver has allocated this device */
-[...]
-truct pci_driver {
-        char *name;
-[...]
-        void (*remove) (struct pci_dev *dev);   /* Device removed (NULL if not a hot-plug capable driver) */
 [...]
 #if defined(__VMKLNX__)
         /* 2008: Update from Linux source */
         u8              revision;       /* PCI revision, low byte of class word */
 #endif /* defined(__VMKLNX__) */
+[...]
+       struct pci_driver *driver;      /* which driver has allocated this device */
+[...]
+struct pci_driver {
+        struct list_head node;
+        char *name;
+[...]
+        void (*remove) (struct pci_dev *dev);   /* Device removed (NULL if not a hot-plug capable driver) */
+[...]
   };
 

 
 
These structures, and based on those from Linux itself
   (a
     similar version of this file can be seen in Linux 2.6.24), and as can
-  be seen above, have been modified to work with “vmkernel”

+  be seen above, have been modified to work with “vmkernel”.

 
 
In LinuxPCIDeviceRemoved(), we saw a macro called with a
   variable, linuxDev which was of type struct pci.
@@ -346,7 +348,7 @@ truct pci_driver {
 
VMKAPI_MODULE_CALL_VOID macro calls driver's code

 
 
The
-  file BLD/build/HEADERS/vmkapi-current-all-public/vmkernel64/release/base/vmkapi_module.h
+  file BLD/build/HEADERS/vmkapi-current-all-public/generic/release/base/vmkapi_module.h
   contains the macro definition of  VMKAPI_MODULE_CALL_VOID,
   which is quoted below (with debug lines removed):
 
@@ -361,8 +363,8 @@ do {                                                    \
 

 
 
When the macro is expanded, it means that (function)(args) is
-  actually expanded to linuxDev->driver->remove(linuxDev).
-  Therefore, we see LinuxPCIDeviceRemoved(), makes directs calls
+  actually expanded to linuxDev->driver->remove(linuxDev).
+  Therefore, we see LinuxPCIDeviceRemoved() makes directs calls
   to a driver's remove() function, by combining with Linux's struct
   pci, and by VMware's introduction of this new calling code.
   Conservancy has confirmed many drivers from Linux are incorporated via
@@ -382,8 +384,8 @@ static struct pci_driver tg3_driver = {
 

 
 
Therefore, when the code in LinuxPCIDeviceRemoved()
-  calls linuxDev->driver->remove(linuxDev), the code ultimately
-  called (in the case where a tg3 card is driven by the kernel)
+  calls linuxDev->driver->remove(linuxDev), the code
+  ultimately called (in the case where a tg3 card is driven by the kernel)
   is tg3_remove_one(), which is found in tg3.c and
   comes directly from Linux.

 
@@ -394,11 +396,11 @@ static struct pci_driver tg3_driver = {
 
 
VMware distribution of binary version of tg3.c

 
-
VMware furthermore distributes a modified version of tg.c in
+
VMware furthermore distributes a modified version of tg3.c in
   binary form.  This can be found in usr/lib/vmware/vmkmod/tg3,
   which is extracted by un-vmtar'ing the file net_tg3.v00 (found
-  on the ESXi 5.5U2 installer ISO image).  Conservancy has confirmed that
-  file is a compiled version of tg3.c

+  on the ESXi 6.0 installer ISO image).  Conservancy has confirmed that
+  file is a compiled version of tg3.c.

 
 
Conclusions

 
@@ -444,20 +446,20 @@ previously-mentioned linux_pci.c,
   
To obtain the source components, follow these steps (no login is required):

 
 
    
-
  1. Visit https://my.vmware.com/web/vmware/details?downloadGroup=ESXI55U2_OSS&productId=353.
    2. 
+
  2. Visit https://my.vmware.com/web/vmware/details?downloadGroup=ESXI600_OSS&productId=491.
    3. 
 
 
  3. Click the “Download” button beside the text that reads
-“Open Source Code for VMware vSphere ESXi 5.5 Update 2”.
    4. 
+“Open source software accompanying ESXi”.
 
 
  4. Confirm that the SHA-1 hash matches the published one
-  (d121634668a137ec808b63679fd941cef9a59715), found under “Read
+  (35811b981470abe8b606d8a7a97c9795ce570597), found under “Read
   More” on that web page.
    5. 
 
 
  5. Mount (or otherwise open) the
-  downloaded VMware-ESX-550U2-ODP.iso.
    6. 
+  downloaded VMware-ESXI-600-ODP.iso.
 
 
  6. Extract vmkdrivers/src_92/vmklinux_92/vmware/linux_pci.c
-  and BLD/build/HEADERS/vmkapi-current-all-public/vmkernel64/release/device/vmkapi_pci_incompat.h
+  and BLD/build/HEADERS/vmkapi-current-all-public/generic/release/hardware/vmkapi_pci_incompat.h
   from vmkdrivers-gpl/vmkdrivers-gpl.tgz with tar and gzip.
    7. 
 
 
  7. Generate vmklinux_9 by following the steps
@@ -465,11 +467,11 @@ previously-mentioned linux_pci.c,
   (Note: vmklinux_9 is also available pre-built on a running
   ESXi system; see below for instructions on how to access it).
    8. 
 
-
  8. You may need the “Supporting Toolchain packages for VMware
-  vSphere ESXi 5.5.0 Update 2” file from the above download page to
+
  9. You may need the “Open source software disclosure package for
+  toolchain” file from the above download page to
   complete the build — upon downloading you will find it is named
-  VMware-TOOLCHAIN-550u2-ODP.iso and has a SHA-1 hash of
-  f679e81ffb2f92729917bbc64c2d541cf75b5b94.
    10. 
+  VMware-TOOLCHAIN-600-ODP.iso and has a SHA-1 hash of
+  9a68df4cbeb645c25002a02f11b1923f98d3d5b5.
 
 

 
@@ -481,7 +483,7 @@ previously-mentioned linux_pci.c,
 
  • Click the “Activate Now” link in the follow-up email.  Enter
   the password used at registration time.  Click “Continue”.
    • 
 
-
  • Visit https://my.vmware.com/web/vmware/evalcenter?p=free-esxi5.
    • 
+
  • Visit https://my.vmware.com/web/vmware/evalcenter?p=free-esxi6.
    • 
 
 
  • Click “Register” (under the text that reads “You have
   not registered for this product”).
    • 
@@ -489,16 +491,16 @@ previously-mentioned linux_pci.c,
 
  • Enter the number of servers you plan to install on (e.g., 1).  Click
   “Continue”.
    • 
 
-
  • If the “VMware vSphere Hypervisor 5.5 Update 2 –
+
  • If the “VMware vSphere Hypervisor 6.0 –
   Binaries” section is not expanded, click the plus sign next to it.
    • 
 
 
  • Click the “Manually Download” link that's beside “ESXi
-  5.5 Update 2 ISO image (Includes VMware Tools)”.
    • 
+  ISO image (Includes VMware Tools)”.
 
-
  • Confirm that the SHA-1 hash matches the published one (9475938b51cafc86c8b17d09f2493cb6b4fae927).
    • 
+
  • Confirm that the SHA-1 hash matches the published one (a38a9d37ea529329338de049679c1dd1687d3860).
    • 
 
 
  • Mount (or open via some other means) the
-downloaded VMware-VMvisor-Installer-5.5.0.update02-2068190.x86_64.iso.
    • 
+downloaded VMware-VMvisor-Installer-6.0.0-2494585.x86_64.iso.
 
 
  • Find the k.b00 file in the root directory.  Extract it
 using zcat k.b00 > vmvisor64-vmkernel (or a similar command).