From 49e3c43299e87f466048ee6dcfb6fadc778bb07b Mon Sep 17 00:00:00 2001 From: Ben Sturmfels Date: Fri, 23 Feb 2024 15:06:59 +1100 Subject: [PATCH] poddjango: Further lint fixes --- conservancy/podjango/feeds.py | 26 +++++++++++++++++++------- conservancy/podjango/urls.py | 4 ++-- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/conservancy/podjango/feeds.py b/conservancy/podjango/feeds.py index 601434fe..a0e32aa2 100644 --- a/conservancy/podjango/feeds.py +++ b/conservancy/podjango/feeds.py @@ -29,10 +29,13 @@ from .models import Cast # FIXME: Settings here should not be hard-coded for given casts, but # should instead have settings from the main screen. -class CastFeedBase(Feed): - def copyright_holder(self): return "Bradley M. Kuhn, Karen M. Sandler" - def license_no_html(self): return "Licensed under a Creative Commons Attribution-Share Alike 3.0 USA License." +class CastFeedBase(Feed): + def copyright_holder(self): + return "Bradley M. Kuhn, Karen M. Sandler" + + def license_no_html(self): + return "Licensed under a Creative Commons Attribution-Share Alike 3.0 USA License." def item_copyright(self, item): year = 2008 @@ -132,12 +135,14 @@ def podcast_helper_add_root_elements(self, handler): 'type': "application/rss+xml"}) years = {} - for ii in self.items: years[ii['year']] = 1 + for ii in self.items: + years[ii['year']] = 1 copyrightString = "" ll = years.keys() sorted(ll) - for yy in ll: copyrightString += "%d, " % yy + for yy in ll: + copyrightString += "%d, " % yy copyrightString += "%s. %s" % (self.feed['copyrightHolder'], self.feed['copyrightLicense']) handler.addQuickElement('copyright', copyrightString) @@ -156,6 +161,7 @@ def podcast_helper_add_item_elements(self, handler, item): 'fileSize': item['enclosure'].length, 'type': item['enclosure'].mime_type}) + # http://www.feedforall.com/itune-tutorial-tags.htm # http://www.feedforall.com/mediarss.htm class iTunesFeedType(Rss201rev2Feed): @@ -235,17 +241,23 @@ class CastFeed(CastFeedBase): class Mp3CastFeed(CastFeed): - def item_enclosure_mime_type(self): return "audio/mpeg" + def item_enclosure_mime_type(self): + return "audio/mpeg" + def item_enclosure_url(self, item): return add_domain(self.current_site.domain, item.mp3_path, self.is_secure) + def item_enclosure_length(self, item): return item.mp3_length class OggCastFeed(CastFeed): - def item_enclosure_mime_type(self): return "audio/ogg" + def item_enclosure_mime_type(self): + return "audio/ogg" + def item_enclosure_url(self, item): return add_domain(self.current_site.domain, item.ogg_path, self.is_secure) + def item_enclosure_length(self, item): return item.ogg_length diff --git a/conservancy/podjango/urls.py b/conservancy/podjango/urls.py index 31165d12..1fab0391 100644 --- a/conservancy/podjango/urls.py +++ b/conservancy/podjango/urls.py @@ -57,8 +57,8 @@ urlpatterns = [ ] if settings.DEBUG: - from django.conf.urls.static import static - urlpatterns += static('/', document_root='podjango/static') + from django.conf.urls.static import static + urlpatterns += static('/', document_root='podjango/static') def all_tags_by_use_amount():