From 8d77023aec4c78319d8bc01e4b4a7b925e8b1687 Mon Sep 17 00:00:00 2001 From: Sachi King Date: Mon, 24 Apr 2017 23:35:04 +1000 Subject: [PATCH] Remove AceEditor I cannot find the benifit to this over the base editor. Tabs work, but that's pretty minimal. And tabs don't work on GitLab or GitHub, so I don't feel not having that is substantual to functionality. --- pinaxcon/monkey_patch.py | 13 ------------- pinaxcon/proposals/forms.py | 22 +--------------------- pinaxcon/widgets.py | 17 ----------------- 3 files changed, 1 insertion(+), 51 deletions(-) delete mode 100644 pinaxcon/widgets.py diff --git a/pinaxcon/monkey_patch.py b/pinaxcon/monkey_patch.py index fbfd6a0a..c0102512 100644 --- a/pinaxcon/monkey_patch.py +++ b/pinaxcon/monkey_patch.py @@ -9,7 +9,6 @@ class MonkeyPatchMiddleware(object): def do_monkey_patch(): - patch_speaker_profile_form() patch_stripe_payment_form() # Remove this function from existence @@ -17,18 +16,6 @@ def do_monkey_patch(): do_monkey_patch = lambda: None # noqa: E731 -def patch_speaker_profile_form(): - ''' Replaces textarea widgets with markdown editors. ''' - - from . import widgets - from symposion.speakers.forms import SpeakerForm - - fields = SpeakerForm.base_fields - fields["biography"].widget = widgets.AceMarkdownEditor() - fields["experience"].widget = widgets.AceMarkdownEditor() - fields["accessibility"].widget = widgets.AceMarkdownEditor() - - def patch_stripe_payment_form(): # noqa: C901 import inspect # Oh no. diff --git a/pinaxcon/proposals/forms.py b/pinaxcon/proposals/forms.py index c85a8811..79ec73ad 100644 --- a/pinaxcon/proposals/forms.py +++ b/pinaxcon/proposals/forms.py @@ -1,8 +1,6 @@ from django import forms -from pinaxcon import widgets - -from .models import TalkProposal, TutorialProposal, MiniconfProposal +from pinaxcon.proposals.models import TalkProposal, TutorialProposal, MiniconfProposal class ProposalForm(forms.ModelForm): @@ -35,12 +33,6 @@ class TalkProposalForm(ProposalForm): "materials_release", ] - widgets = { - "abstract": widgets.AceMarkdownEditor(), - "private_abstract": widgets.AceMarkdownEditor(), - "technical_requirements": widgets.AceMarkdownEditor(), - } - class TutorialProposalForm(ProposalForm): @@ -59,12 +51,6 @@ class TutorialProposalForm(ProposalForm): "materials_release", ] - widgets = { - "abstract": widgets.AceMarkdownEditor(), - "private_abstract": widgets.AceMarkdownEditor(), - "technical_requirements": widgets.AceMarkdownEditor(), - } - class MiniconfProposalForm(ProposalForm): @@ -76,9 +62,3 @@ class MiniconfProposalForm(ProposalForm): "private_abstract", "technical_requirements", ] - - widgets = { - "abstract": widgets.AceMarkdownEditor(), - "private_abstract": widgets.AceMarkdownEditor(), - "technical_requirements": widgets.AceMarkdownEditor(), - } diff --git a/pinaxcon/widgets.py b/pinaxcon/widgets.py deleted file mode 100644 index f3a3e6a0..00000000 --- a/pinaxcon/widgets.py +++ /dev/null @@ -1,17 +0,0 @@ -from django import forms - - -class AceMarkdownEditor(forms.Textarea): - - def render(self, name, value, attrs): - original = super(AceMarkdownEditor, self).render(name, value, attrs) - ret = ''' - %s - - ''' % (original, attrs["id"]) - - return ret