From 851c37508a1f3611deaf561261c2717f9ac4b2ec Mon Sep 17 00:00:00 2001
From: Christopher Neugebauer <chrisjrn@gmail.com>
Date: Mon, 19 Sep 2016 13:39:39 +1000
Subject: [PATCH] Factors out annotating objects by cart status

---
 registrasion/reporting/views.py | 46 ++++++++++++++++++---------------
 1 file changed, 25 insertions(+), 21 deletions(-)

diff --git a/registrasion/reporting/views.py b/registrasion/reporting/views.py
index 237330f7..7770d76e 100644
--- a/registrasion/reporting/views.py
+++ b/registrasion/reporting/views.py
@@ -178,19 +178,8 @@ def credit_note_refunds():
     )
 
 
-@report_view("Product status", form_type=forms.ProductAndCategoryForm)
-def product_status(request, form):
-    ''' Summarises the inventory status of the given items, grouping by
-    invoice status. '''
-
-    products = form.cleaned_data["product"]
-    categories = form.cleaned_data["category"]
-
-    items = commerce.ProductItem.objects.filter(
-        Q(product__in=products) | Q(product__category__in=categories),
-    ).select_related("cart", "product")
-
-    items = items.annotate(
+def group_by_cart_status(queryset, order, values):
+    queryset = queryset.annotate(
         is_reserved=Case(
             When(cart__in=commerce.Cart.reserved_carts(), then=Value(True)),
             default=Value(False),
@@ -198,14 +187,8 @@ def product_status(request, form):
         ),
     )
 
-    items = items.order_by(
-        "product__category__order",
-        "product__order",
-    ).values(
-        "product",
-        "product__category__name",
-        "product__name",
-    ).annotate(
+    values = queryset.order_by(*order).values(*values)
+    values = values.annotate(
         total_paid=Sum(Case(
             When(
                 cart__status=commerce.Cart.STATUS_PAID,
@@ -242,6 +225,27 @@ def product_status(request, form):
         )),
     )
 
+    return values
+
+
+@report_view("Product status", form_type=forms.ProductAndCategoryForm)
+def product_status(request, form):
+    ''' Summarises the inventory status of the given items, grouping by
+    invoice status. '''
+
+    products = form.cleaned_data["product"]
+    categories = form.cleaned_data["category"]
+
+    items = commerce.ProductItem.objects.filter(
+        Q(product__in=products) | Q(product__category__in=categories),
+    ).select_related("cart", "product")
+
+    items = group_by_cart_status(
+        items,
+        ["product__category__order", "product__order"],
+        ["product", "product__category__name", "product__name"],
+    )
+
     headings = [
         "Product", "Paid", "Reserved", "Unreserved", "Refunded",
     ]