From 7fe5a09bfb9b63684e8fe541eb12adb4bbf78168 Mon Sep 17 00:00:00 2001 From: James Polley Date: Tue, 8 Aug 2017 23:00:36 +0000 Subject: [PATCH] Return an integer for the slice index. Resolves: File "/app/symposion_app/vendor/symposion/reviews/views.py", line 230, in review_random_proposal proposals = proposals[:(len(proposals) + 1) / 2] TypeError: slice indices must be integers or None or have an __index__ method --- vendor/symposion/reviews/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vendor/symposion/reviews/views.py b/vendor/symposion/reviews/views.py index 38815309..294913d6 100644 --- a/vendor/symposion/reviews/views.py +++ b/vendor/symposion/reviews/views.py @@ -1,4 +1,5 @@ import csv +import math import random from django.contrib.auth.decorators import login_required @@ -226,8 +227,7 @@ def review_random_proposal(request, section_slug): proposals = list(proposals) proposals.sort(key=lambda proposal: proposal.total_votes) # The first half is the median or less. - # The +1 means we round _up_. - proposals = proposals[:(len(proposals) + 1) / 2] + proposals = proposals[:math.ceil(len(proposals) / 2)] # Realistically, there shouldn't be all that many proposals to choose # from, so this should be cheap.