Conservancy/symposion_app
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Factors _test_voucher() method into CartController

Browse source
This commit is contained in:
Christopher Neugebauer 2016-04-06 12:09:16 +10:00
parent 7d97d2d2de
commit 6f28c20b70
1 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
registrasion/controllers/cart.py
View file

@ -175,16 +175,26 @@ class CartController(object):
def apply_voucher(self, voucher_code): def apply_voucher(self, voucher_code):
''' Applies the voucher with the given code to this cart. ''' ''' Applies the voucher with the given code to this cart. '''
# Is voucher exhausted?
active_carts = rego.Cart.reserved_carts()
# Try and find the voucher # Try and find the voucher
voucher = rego.Voucher.objects.get(code=voucher_code.upper()) voucher = rego.Voucher.objects.get(code=voucher_code.upper())
self._test_voucher(voucher)
# If successful...
self.cart.vouchers.add(voucher)
self.end_batch()
def _test_voucher(self, voucher):
''' Tests whether this voucher is allowed to be applied to this cart.
Raises ValidationError if not. '''
# Is voucher exhausted?
active_carts = rego.Cart.reserved_carts()
# It's invalid for a user to enter a voucher that's exhausted # It's invalid for a user to enter a voucher that's exhausted
carts_with_voucher = active_carts.filter(vouchers=voucher) carts_with_voucher = active_carts.filter(vouchers=voucher)
if len(carts_with_voucher) >= voucher.limit: if len(carts_with_voucher) >= voucher.limit:
raise ValidationError("This voucher is no longer available") raise ValidationError("Voucher %s is no longer available" % voucher.code)
# It's not valid for users to re-enter a voucher they already have # It's not valid for users to re-enter a voucher they already have
user_carts_with_voucher = rego.Cart.objects.filter( user_carts_with_voucher = rego.Cart.objects.filter(
@ -195,9 +205,6 @@ class CartController(object):
if len(user_carts_with_voucher) > 0: if len(user_carts_with_voucher) > 0:
raise ValidationError("You have already entered this voucher.") raise ValidationError("You have already entered this voucher.")
# If successful...
self.cart.vouchers.add(voucher)
self.end_batch()
def validate_cart(self): def validate_cart(self):
''' Determines whether the status of the current cart is valid; ''' Determines whether the status of the current cart is valid;