Conservancy/symposion_app
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove jquery.history.js reference

Browse source 
* This reference was added in the very distant past
* But jquery.history.js itself has never been in the repo
* pyconau-2017 team resolved the dilemma but dropping
  jquery.history.js into the repo
* But as near as I can tell, this does nothing except in obsolete
  older browsers. The fact that it's been broken ever since it was
  "added" is highly suggestive of it never having ever been used or
  needed
* So, trim the fat. It's possible that this might break an older
  browser that needs the functionality jquery.history.js provides -
  except that such a browser would *already* be broken because
  jquery.history.js has never actually been around to be used.
* If we ever do need this functionality, we can revert this
  change.. and then we'd have to drop in jquery.history.js. In that
  circumstance,
  https://github.com/pyconau2017/symposion/commit/34bc7c0 may be of interest.
This commit is contained in:
James Polley 2017-09-16 21:10:57 +10:00
parent 7a4ddcee6d
commit 6e17b6d13d
1 changed files with 0 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
pinaxcon/templates/symposion/reviews/review_detail.html
View file

@ -188,28 +188,3 @@
</div>
{% endblock %}
{% block extra_script %}
{{ block.super }}
<script src="{{ STATIC_URL }}symposion/js/jquery.history.js"></script>
<script type="text/javascript">
$(function() {
var History = window.History;
$(window).bind("anchorchange", function() {
$(".nav-tabs a[href='" + location.hash + "']").click();
});
$('.nav-tabs a[data-toggle="tab"]').on('shown', function (e) {
if (History.enabled) {
History.pushState(null, null, $(e.target).attr("href"));
}
});
if (window.location.hash !== '') {
$('.nav-tabs a[href="' + window.location.hash + '"]').tab('show')
}
});
</script>
{% endblock %}