Conservancy/symposion_app
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removes div-by-zero error if the first vote is an abstention

Browse source
This commit is contained in:
Christopher Neugebauer 2016-06-18 17:01:56 +10:00
parent 47a6f212f2
commit 6e133970d9
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
symposion/reviews/models.py
View file

@ -5,6 +5,7 @@ from decimal import Decimal
from django.db import models from django.db import models
from django.db.models import Q, F from django.db.models import Q, F
from django.db.models import Case, When, Value
from django.db.models.signals import post_save from django.db.models.signals import post_save
from django.contrib.auth.models import User from django.contrib.auth.models import User
@ -16,13 +17,18 @@ from symposion.schedule.models import Presentation
def score_expression(): def score_expression():
return ( score = (
(2 * F("plus_two") + F("plus_one")) - (2 * F("plus_two") + F("plus_one")) -
(F("minus_one") + 2 * F("minus_two")) (F("minus_one") + 2 * F("minus_two"))
) / ( ) / (
F("vote_count") - F("abstain") * 1.0 F("vote_count") - F("abstain") * 1.0
) )
return Case(
When(vote_count=F("abstain"), then=Value("0")), # no divide by zero
default=score,
)
class Votes(object): class Votes(object):
ABSTAIN = "0" ABSTAIN = "0"