Conservancy/symposion_app
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Does more select_related and bulk_create calls

Browse source
This commit is contained in:
Christopher Neugebauer 2016-04-28 19:58:09 +10:00
parent fd5cf50fab
commit 4fb569d935
2 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
registrasion/controllers/cart.py
View file

@ -358,6 +358,7 @@ class CartController(object):
errors.append(ve) errors.append(ve)
items = commerce.ProductItem.objects.filter(cart=cart) items = commerce.ProductItem.objects.filter(cart=cart)
items = items.select_related("product", "product__category")
product_quantities = list((i.product, i.quantity) for i in items) product_quantities = list((i.product, i.quantity) for i in items)
try: try:

22
registrasion/controllers/invoice.py
View file

@ -99,6 +99,10 @@ class InvoiceController(ForId, object):
) )
product_items = commerce.ProductItem.objects.filter(cart=cart) product_items = commerce.ProductItem.objects.filter(cart=cart)
product_items = product_items.select_related(
"product",
"product__category",
)
if len(product_items) == 0: if len(product_items) == 0:
raise ValidationError("Your cart is empty.") raise ValidationError("Your cart is empty.")
@ -106,29 +110,41 @@ class InvoiceController(ForId, object):
product_items = product_items.order_by( product_items = product_items.order_by(
"product__category__order", "product__order" "product__category__order", "product__order"
) )
discount_items = commerce.DiscountItem.objects.filter(cart=cart) discount_items = commerce.DiscountItem.objects.filter(cart=cart)
discount_items = discount_items.select_related(
"discount",
"product",
"product__category",
)
line_items = []
invoice_value = Decimal() invoice_value = Decimal()
for item in product_items: for item in product_items:
product = item.product product = item.product
line_item = commerce.LineItem.objects.create( line_item = commerce.LineItem(
invoice=invoice, invoice=invoice,
description="%s - %s" % (product.category.name, product.name), description="%s - %s" % (product.category.name, product.name),
quantity=item.quantity, quantity=item.quantity,
price=product.price, price=product.price,
product=product, product=product,
) )
line_items.append(line_item)
invoice_value += line_item.quantity * line_item.price invoice_value += line_item.quantity * line_item.price
for item in discount_items: for item in discount_items:
line_item = commerce.LineItem.objects.create( line_item = commerce.LineItem(
invoice=invoice, invoice=invoice,
description=item.discount.description, description=item.discount.description,
quantity=item.quantity, quantity=item.quantity,
price=cls.resolve_discount_value(item) * -1, price=cls.resolve_discount_value(item) * -1,
product=item.product, product=item.product,
) )
line_items.append(line_item)
invoice_value += line_item.quantity * line_item.price invoice_value += line_item.quantity * line_item.price
commerce.LineItem.objects.bulk_create(line_items)
invoice.value = invoice_value invoice.value = invoice_value
invoice.save() invoice.save()