Mass style-check update

Seems okay.

pinaxcon/csrf_view.py

@@ -1,10 +1,10 @@
 from django.conf import settings
 from django.http import HttpResponseForbidden
-from django.shortcuts import redirect
 from django.template import Context, RequestContext, loader
 from django.utils.translation import ugettext as _
 from django.utils.version import get_docs_version
 
+
 def csrf_failure(request, reason=""):
 
     from django.middleware.csrf import REASON_BAD_TOKEN, REASON_NO_REFERER, REASON_NO_CSRF_COOKIE

pinaxcon/disable_cscache.py

@@ -1,7 +1,7 @@
 from django.utils.cache import add_never_cache_headers
 
+
 class DisableClientSideCachingMiddleware(object):
     def process_response(self, request, response):
         add_never_cache_headers(response)
         return response
-

pinaxcon/monkey_patch.py

@@ -1,5 +1,5 @@
 from django.conf import settings
-from django.core.mail import EmailMultiAlternatives
+from django.core.mail import EmailMultiAlternatives  # noqa: F401
 from functools import wraps
 
 
@@ -19,7 +19,7 @@ def do_monkey_patch():
 
     # Remove this function from existence
     global do_monkey_patch
-    do_monkey_patch = lambda: None
+    do_monkey_patch = lambda: None  # noqa: E731
 
 
 def patch_speaker_profile_form():
@@ -34,7 +34,7 @@ def patch_speaker_profile_form():
     fields["accessibility"].widget = widgets.AceMarkdownEditor()
 
 
-def patch_mail_to_send_bcc():
+def patch_mail_to_send_bcc():  # noqa: C901
     ''' Patches django.core.mail's message classes to send a BCC e-mail to
     the default BCC e-mail address. '''
 
@@ -80,7 +80,6 @@ def patch_mail_to_send_bcc():
 
         return tuple(a[:pos] + (bcc,) + a[pos + 1:])
 
-
     def patch_bcc_keyword(f, k):
         ''' Adds our BCC list to the BCC list in the keyword arguments, and
         returns the new version of the keyword arguments.
@@ -139,13 +138,14 @@ def fix_sitetree_check_access_500s():
 
     SiteTree.check_access = check_access
 
+
 def never_cache_login_page():
     from django.views.decorators.cache import never_cache
     from account.views import LoginView
     LoginView.get = never_cache(LoginView.get)
 
 
-def patch_stripe_payment_form():
+def patch_stripe_payment_form():  # noqa: C901
 
     import inspect  # Oh no.
     from django.http.request import HttpRequest

pinaxcon/proposals/admin.py

@@ -18,7 +18,6 @@ from symposion.proposals import models as symposion_models
 @admin.register(models.KnowledgeProposal)
 @admin.register(models.LawProposal)
 @admin.register(models.OpenHardwareProposal)
-
 class CategoryAdmin(admin.ModelAdmin):
 
     class AdditionalSpeakerInline(admin.TabularInline):

pinaxcon/proposals/forms.py

@@ -8,6 +8,7 @@ from .models import KernelProposal, OpenRadioProposal, SecurityProposal
 from .models import GamesProposal, TestingProposal, LawProposal, OpenHardwareProposal
 from .models import KnowledgeProposal
 
+
 class ProposalForm(forms.ModelForm):
 
     def clean_description(self):
@@ -84,6 +85,7 @@ class MiniconfProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class SysAdminProposalForm(ProposalForm):
 
     class Meta:
@@ -107,6 +109,7 @@ class SysAdminProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class WriteTheDocsProposalForm(ProposalForm):
 
     class Meta:
@@ -130,6 +133,7 @@ class WriteTheDocsProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class RadioProposalForm(ProposalForm):
 
     class Meta:
@@ -152,6 +156,7 @@ class RadioProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class KernelProposalForm(ProposalForm):
 
     class Meta:
@@ -174,6 +179,7 @@ class KernelProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class WootconfProposalForm(ProposalForm):
 
     class Meta:
@@ -196,6 +202,7 @@ class WootconfProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class SecurityProposalForm(ProposalForm):
 
     class Meta:
@@ -218,6 +225,7 @@ class SecurityProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class GamesProposalForm(ProposalForm):
 
     class Meta:
@@ -241,6 +249,7 @@ class GamesProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class TestingProposalForm(ProposalForm):
 
     class Meta:
@@ -263,6 +272,7 @@ class TestingProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class KnowledgeProposalForm(ProposalForm):
 
     class Meta:
@@ -285,6 +295,7 @@ class KnowledgeProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class LawProposalForm(ProposalForm):
 
     class Meta:
@@ -307,6 +318,7 @@ class LawProposalForm(ProposalForm):
             "technical_requirements": widgets.AceMarkdownEditor(),
         }
 
+
 class OpenHardwareProposalForm(ProposalForm):
 
     class Meta:

pinaxcon/proposals/models.py

@@ -45,16 +45,19 @@ class TalkProposal(Proposal):
     class Meta:
         verbose_name = "talk proposal"
 
+
 class TutorialProposal(Proposal):
 
     class Meta:
         verbose_name = "tutorial proposal"
 
+
 class MiniconfProposal(ProposalBase):
 
     class Meta:
         verbose_name = "miniconf proposal"
 
+
 class SysAdminProposal(Proposal):
 
     TYPE_SHORT_PRESENTATION = 1
@@ -65,12 +68,14 @@ class SysAdminProposal(Proposal):
         (TYPE_LIGHTNING_TALK, "Lightning Talk (5-10 min)"),
     ]
 
-    talk_format = models.IntegerField(choices=TALK_FORMATS,
+    talk_format = models.IntegerField(
+        choices=TALK_FORMATS,
         help_text="Please indicate your preferred talk length in the private abstract field below.")
 
     class Meta:
         verbose_name = "System Administration Miniconf Proposal"
 
+
 class WriteTheDocsProposal(Proposal):
 
     TYPE_LONG_PRESENTATION = 1
@@ -86,26 +91,31 @@ class WriteTheDocsProposal(Proposal):
     class Meta:
         verbose_name = "WriteThe Docs Miniconf Proposal"
 
+
 class OpenRadioProposal(Proposal):
 
     class Meta:
         verbose_name = "OpenRadio Miniconf Proposal"
 
+
 class WootconfProposal(Proposal):
 
     class Meta:
         verbose_name = "WOOTCONF Miniconf Proposal"
 
+
 class KernelProposal(Proposal):
 
     class Meta:
         verbose_name = "Kernel Miniconf Proposal"
 
+
 class SecurityProposal(Proposal):
 
     class Meta:
         verbose_name = "Security/Privacy Miniconf Proposal"
 
+
 class GamesProposal(Proposal):
 
     TYPE_PRESENTATION = 1
@@ -123,21 +133,25 @@ class GamesProposal(Proposal):
     class Meta:
         verbose_name = "Games and FOSS Miniconf Proposal"
 
+
 class TestingProposal(Proposal):
 
     class Meta:
         verbose_name = "Testing/Automation Miniconf Proposal"
 
+
 class KnowledgeProposal(Proposal):
 
     class Meta:
         verbose_name = "Open Knowledge Australia Miniconf Proposal"
 
+
 class LawProposal(Proposal):
 
     class Meta:
         verbose_name = "Open Law and Policy Miniconf Proposal"
 
+
 class OpenHardwareProposal(Proposal):
 
     TYPE_NORMAL_PRESENTATION = 1

pinaxcon/registrasion/forms.py

@@ -28,6 +28,5 @@ class ProfileForm(forms.ModelForm):
             "past_lca": forms.widgets.CheckboxSelectMultiple(),
         }
 
-
     class Media:
         js = ("lca2017/js/profile_form.js", )

pinaxcon/registrasion/management/commands/populate_inventory.py

@@ -4,13 +4,15 @@ from datetime import timedelta
 from decimal import Decimal
 from django.contrib.auth.models import Group
 from django.core.exceptions import ObjectDoesNotExist
-from django.core.management.base import BaseCommand, CommandError
+from django.core.management.base import BaseCommand
 
 from registrasion.models import inventory as inv
 from registrasion.models import conditions as cond
 from symposion import proposals
 
+
 class Command(BaseCommand):
+
     help = 'Populates the inventory with the LCA2017 inventory model'
 
     def add_arguments(self, parser):

pinaxcon/registrasion/views.py

@@ -1,12 +1,8 @@
-from django.conf import settings
-from django.contrib.auth.decorators import login_required
 from django.contrib import messages
-from django.core.exceptions import ObjectDoesNotExist
 from django.core.exceptions import ValidationError
 from django.http import Http404
 from django.shortcuts import get_object_or_404
 from django.shortcuts import redirect
-from django.shortcuts import render
 
 from registrasion import models as rego
 from registrasion.controllers.invoice import InvoiceController

pinaxcon/settings.py

@@ -1,5 +1,4 @@
 import os
-import dj_database_url
 from django.utils.crypto import get_random_string
 
 
@@ -308,6 +307,6 @@ try:
     LOCAL_SETTINGS
 except NameError:
     try:
-        from local_settings import *
+        from local_settings import *  # noqa: F401,F403
     except ImportError:
         pass

pinaxcon/templatetags/lca2017_tags.py

@@ -1,6 +1,5 @@
 import cms_pages
 import hashlib
-import urllib
 
 from decimal import Decimal
 from django import template
@@ -55,7 +54,9 @@ def speaker_photo(context, speaker, size):
     else:
         email = speaker.user.email.encode("utf-8")
         md5sum = hashlib.md5(email.strip().lower()).hexdigest()
-        url = "https://secure.gravatar.com/avatar/%s?s=%d&d=%s" % (md5sum, size, "https://linux.conf.au/site_media/static/lca2017/images/speaker-fallback-devil.jpg")
+        fallback_image = ("https://linux.conf.au/site_media/static/lca2017"
+                          "/images/speaker-fallback-devil.jpg")
+        url = "https://secure.gravatar.com/avatar/%s?s=%d&d=%s" % (md5sum, size, fallback_image)
 
         return url
 
@@ -94,6 +95,7 @@ def gst(amount):
 def conference_name():
     return conference_models.Conference.objects.get(id=CONFERENCE_ID).title
 
+
 @register.filter()
 def trackname(room, day):
     try:

pinaxcon/templatetags/pyconau2017_tags.py

@@ -1,6 +1,5 @@
 import cms_pages
 import hashlib
-import urllib
 
 import os
 
@@ -57,7 +56,9 @@ def speaker_photo(context, speaker, size):
     else:
         email = speaker.user.email.encode("utf-8")
         md5sum = hashlib.md5(email.strip().lower()).hexdigest()
-        url = "https://secure.gravatar.com/avatar/%s?s=%d&d=%s" % (md5sum, size, "https://2017.pycon-au.org/site_media/static/pyconau23017/images/speaker-fallback-devil.jpg")
+        fallback_image = ("https://2017.pycon-au.org/site_media/static"
+                          "/pyconau23017/images/speaker-fallback-devil.jpg")
+        url = "https://secure.gravatar.com/avatar/%s?s=%d&d=%s" % (md5sum, size, fallback_image)
 
         return url
 
@@ -96,6 +97,7 @@ def gst(amount):
 def conference_name():
     return conference_models.Conference.objects.get(id=CONFERENCE_ID).title
 
+
 @register.filter()
 def trackname(room, day):
     try:
@@ -104,11 +106,11 @@ def trackname(room, day):
         track_name = None
     return track_name
 
+
 @register.simple_tag()
 def sponsor_thumbnail(sponsor_logo):
     if sponsor_logo is not None:
         if sponsor_logo.upload:
             logo_file = os.path.join(settings.MEDIA_URL, str(sponsor_logo.upload))
             return logo_file
-
     return ""

pinaxcon/urls.py

@@ -1,5 +1,5 @@
 from django.conf import settings
-from django.conf.urls import patterns, include, url
+from django.conf.urls import include, url
 from django.conf.urls.static import static
 from django.views.generic import TemplateView
 
@@ -11,9 +11,6 @@ from django.contrib import admin
 import symposion.views
 
 
-
-import sys
-
 urlpatterns = [
     url(r"^admin/", include(admin.site.urls)),
 

pinaxcon/widgets.py

@@ -1,5 +1,6 @@
 from django import forms
 
+
 class AceMarkdownEditor(forms.Textarea):
 
     def render(self, name, value, attrs):