Conservancy/symposion_app
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adds validation code to make sure that only one discount condition is applicable per product

Browse source
This commit is contained in:
Christopher Neugebauer 2016-01-22 21:53:30 +11:00
parent 3f3db53232
commit 2e89bc4887
1 changed files with 40 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
registrasion/models.py
View file

@ -143,10 +143,26 @@ class DiscountForProduct(models.Model):
raise ValidationError( raise ValidationError(
_("Discount may only have a percentage or only a price.")) _("Discount may only have a percentage or only a price."))
prods = DiscountForProduct.objects.filter(
discount=self.discount,
product=self.product)
cats = DiscountForCategory.objects.filter(
discount=self.discount,
category=self.product.category)
if len(prods) > 1 or self not in prods:
raise ValidationError(
_("You may only have one discount line per product"))
if len(cats) != 0:
raise ValidationError(
_("You may only have one discount for "
"a product or its category"))
discount = models.ForeignKey(DiscountBase, on_delete=models.CASCADE) discount = models.ForeignKey(DiscountBase, on_delete=models.CASCADE)
product = models.ForeignKey(Product, on_delete=models.CASCADE) product = models.ForeignKey(Product, on_delete=models.CASCADE)
percentage = models.DecimalField(max_digits=4, decimal_places=1, null=True) percentage = models.DecimalField(
price = models.DecimalField(max_digits=8, decimal_places=2, null=True) max_digits=4, decimal_places=1, null=True, blank=True)
price = models.DecimalField(
max_digits=8, decimal_places=2, null=True, blank=True)
quantity = models.PositiveIntegerField() quantity = models.PositiveIntegerField()
@ -158,12 +174,26 @@ class DiscountForCategory(models.Model):
def __str__(self): def __str__(self):
return "%s%% off %s" % (self.percentage, self.category) return "%s%% off %s" % (self.percentage, self.category)
def clean(self):
prods = DiscountForProduct.objects.filter(
discount=self.discount,
product__category=self.category)
cats = DiscountForCategory.objects.filter(
discount=self.discount,
category=self.category)
if len(prods) != 0:
raise ValidationError(
_("You may only have one discount for "
"a product or its category"))
if len(cats) > 1 or self not in cats:
raise ValidationError(
_("You may only have one discount line per category"))
discount = models.ForeignKey(DiscountBase, on_delete=models.CASCADE) discount = models.ForeignKey(DiscountBase, on_delete=models.CASCADE)
category = models.ForeignKey(Category, on_delete=models.CASCADE) category = models.ForeignKey(Category, on_delete=models.CASCADE)
percentage = models.DecimalField( percentage = models.DecimalField(
max_digits=4, max_digits=4,
decimal_places=1, decimal_places=1)
blank=True)
quantity = models.PositiveIntegerField() quantity = models.PositiveIntegerField()
@ -174,9 +204,12 @@ class TimeOrStockLimitDiscount(DiscountBase):
class Meta: class Meta:
verbose_name = _("Promotional discount") verbose_name = _("Promotional discount")
start_time = models.DateTimeField(null=True, verbose_name=_("Start time")) start_time = models.DateTimeField(
end_time = models.DateTimeField(null=True, verbose_name=_("End time")) null=True, blank=True, verbose_name=_("Start time"))
limit = models.PositiveIntegerField(null=True, verbose_name=_("Limit")) end_time = models.DateTimeField(
null=True, blank=True, verbose_name=_("End time"))
limit = models.PositiveIntegerField(
null=True, blank=True, verbose_name=_("Limit"))
class VoucherDiscount(DiscountBase): class VoucherDiscount(DiscountBase):