Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fulfillFailure: fix reason message to include more data; add who

Browse source 
'who' is now a possible parameter, but default it the old way so it's
not mandatory, and improve the reason message on failures.
This commit is contained in:
Bradley M. Kuhn 2021-02-20 13:02:49 -08:00
parent 839799beac
commit fdf58bb729
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Supporters/lib/Supporters.pm
View file

@ -1360,10 +1360,12 @@ sub fulfillFailure($$) {
return undef return undef
if (not defined $fulfillRecord or not defined $fulfillRecord->{$requestId}); if (not defined $fulfillRecord or not defined $fulfillRecord->{$requestId});
$params->{who} = $fulfillRecord->{who} unless defined $params->{who};
$self->_beginWork; $self->_beginWork;
my $reason = "because $params->{why}, fulfillment failed on " . $fulfillRecord->{$requestId}{date} . " (which was attempted via " . my $reason = "because $params->{why}, fulfillment failed on $TODAY (fulfillment had been attempted via " .
$fulfillRecord->{$requestId}{how} . ')'; "$fulfillRecord->{$requestId}{how} by $fulfillRecord->{$requestId}{who} on $fulfillRecord->{$requestId}{date} )";
my $holdId = $self->holdRequest({donorId => $donorId, requestType => $req->{requestType}, my $holdId = $self->holdRequest({donorId => $donorId, requestType => $req->{requestType},
who => $fulfillRecord->{$requestId}{who}, who => $fulfillRecord->{$requestId}{who},