Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

getReqeust: don't use paramater has setup.

Browse source 
We don't really need lookup based on requestTypeId for this anyway, so
this method really only needs two arguments (perhaps a third optional
argument to be added later).
This commit is contained in:
Bradley M. Kuhn 2015-12-20 14:22:46 -08:00
parent b62283dc74
commit e0f7e66bba
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Supporters/t/Supporters.t
View file

@ -360,20 +360,20 @@ is_deeply($val2, $val,
=cut =cut
dies_ok { $sp->getRequest({}); } "getRequest: dies if supporterId not specified."; dies_ok { $sp->getRequest(undef, undef); } "getRequest: dies if supporterId not specified.";
dies_ok { $sp->getRequest({ supporterId => 0 }); } "getRequest: dies if supporterId invalid."; dies_ok { $sp->getRequest(0, "t-shirt-small-only"); } "getRequest: dies if supporterId invalid.";
dies_ok { $sp->getRequest({ supporterId => $drapperId }); } dies_ok { $sp->getRequest($drapperId, undef); }
"getRequest: dies if requestTypeId / requestType not specified."; "getRequest: dies if requestTypeId / requestType not specified.";
my $tt; my $tt;
lives_ok { $tt = $sp->getRequest({ supporterId => $drapperId, requestType => 'this-one-is-not-there' }); } lives_ok { $tt = $sp->getRequest($drapperId, 'this-one-is-not-there'); }
"getRequest: returns normally with non-existent request."; "getRequest: returns normally with non-existent request.";
is($tt, undef, "getRequest: returns undef for valid supporter and on-existent request."); is($tt, undef, "getRequest: returns undef for valid supporter and on-existent request.");
lives_ok { $tt = $sp->getRequest({ supporterId => $drapperId, requestType => 't-shirt-small-only' }); } lives_ok { $tt = $sp->getRequest($drapperId, 't-shirt-small-only'); }
"getRequest: succeeds with valid parameters."; "getRequest: succeeds with valid parameters.";
is($tt->{requestType}, 't-shirt-small-only', "getRequest: requestType is correct."); is($tt->{requestType}, 't-shirt-small-only', "getRequest: requestType is correct.");
@ -383,7 +383,7 @@ is($tt->{requestConfiguration}, 'Small', "getRequest: configuration is correct."
is($tt->{notes}, 'he probably needs a larger size but this shirt has none', is($tt->{notes}, 'he probably needs a larger size but this shirt has none',
"getRequest: notes are correct."); "getRequest: notes are correct.");
lives_ok { $tt = $sp->getRequest({ supporterId => $drapperId, requestTypeId => $tShirt0RequestTypeId }); } lives_ok { $tt = $sp->getRequest($drapperId, 't-shirt-0'); }
"getRequest: succeeds with valid parameters."; "getRequest: succeeds with valid parameters.";
is($tt->{requestType}, 't-shirt-0', "getRequest: requestType is correct."); is($tt->{requestType}, 't-shirt-0', "getRequest: requestType is correct.");
@ -391,7 +391,7 @@ is($tt->{requestDate}, $today, "getRequest: request date is today.");
is($tt->{requestConfiguration}, 'MenL', "getRequest: configuration is correct."); is($tt->{requestConfiguration}, 'MenL', "getRequest: configuration is correct.");
is($tt->{notes}, undef, "getRequest: notes are undef when null in database."); is($tt->{notes}, undef, "getRequest: notes are undef when null in database.");
lives_ok { $tt = $sp->getRequest({ supporterId => $drapperId, requestType => "join-announce-email-list" }); } lives_ok { $tt = $sp->getRequest($drapperId, "join-announce-email-list"); }
"getRequest: succeeds with valid parameters."; "getRequest: succeeds with valid parameters.";
is($tt->{requestType}, "join-announce-email-list", "getRequest: requestType is correct."); is($tt->{requestType}, "join-announce-email-list", "getRequest: requestType is correct.");