Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fulfillRequest: test had incorrect return value.

Browse source 
fulfillRequest() returns the id, not a hash of values.
This commit is contained in:
Bradley M. Kuhn 2015-12-20 17:07:44 -08:00
parent 3ff735584c
commit cb1ce38650
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Supporters/lib/Supporters.pm
View file

@ -693,7 +693,7 @@ A hash reference, the following keys are considered:
=back =back
Returns the id value of the request entry. Returns the id value of the fulfillment entry.
=cut =cut

8
Supporters/t/Supporters.t
View file

@ -344,15 +344,15 @@ is($sp->getRequestType("does-not-exist"), undef,
"fulfillRequest: requestType not created when fulfillRequest fails."); "fulfillRequest: requestType not created when fulfillRequest fails.");
my $val2; my $lookedUpFulfillmentId;
lives_ok { $val2 = $sp->fulfillRequest( { supporterId => $drapperId, lives_ok { $lookedUpFulfillmentId = $sp->fulfillRequest( { supporterId => $drapperId,
requestType => "t-shirt-small-only", who => 'peggy', requestType => "t-shirt-small-only", who => 'peggy',
how => "left in his office." }); } how => "left in his office." }); }
"fulfillRequest: attempt to fulfill an already-fulfill request does not die ..."; "fulfillRequest: attempt to fulfill an already-fulfill request does not die ...";
is_deeply($val2, $val, is($lookedUpFulfillmentId, $fulfillRequestId,
"fulfillRequest: ... but, rather, returns the same values from the previous fulfillRequest() call."); "fulfillRequest: ... but, rather, returns the same value from the previous fulfillRequest() call.");
=item getRequest =item getRequest