From a82ebfb0a979074d1bd66a0710a928cf95a64347 Mon Sep 17 00:00:00 2001 From: "Bradley M. Kuhn" Date: Tue, 26 Dec 2017 12:32:15 -0800 Subject: [PATCH] _lookupDeliveryError: begun Verify beginnings of implementation --- Supporters/lib/Supporters.pm | 22 ++++++++++++++++++++++ Supporters/t/Supporters.t | 11 +++++++++++ 2 files changed, 33 insertions(+) diff --git a/Supporters/lib/Supporters.pm b/Supporters/lib/Supporters.pm index 906350b..d28c2cd 100644 --- a/Supporters/lib/Supporters.pm +++ b/Supporters/lib/Supporters.pm @@ -2039,6 +2039,28 @@ sub _lookupRequestTypeById($$) { } ###################################################################### +=item _lookupDeliveryError() + +Parameters: + +=over + +=item $self: current object. + +=item $errorName: A scalar string argument that is the error + +=back + +Returns: undef if the error code does not exist in the delivery_error table, +otherwise returns the id for the entry in the delivery_table + +=cut + +sub _lookupDeliveryError($$) { +} + +###################################################################### + =item _lookupEmailAddress() Parameters: diff --git a/Supporters/t/Supporters.t b/Supporters/t/Supporters.t index c2f03d3..b05a24a 100644 --- a/Supporters/t/Supporters.t +++ b/Supporters/t/Supporters.t @@ -376,9 +376,20 @@ ok($same == $paypalPayerAddressType, "addAddressType: lookup returns same as the # Add an "undeliverable" delivery_error type +$val = 1; +lives_ok { $val = $sp->_lookupDeliveryError("undeliverable"); }, + "_lookupDeliveryError: succeeds for unknown error ..."; + +is($val, undef, "_lookupDeliveryError: ... but returns undef"); + my $sth = $sp->dbh->prepare("INSERT INTO delivery_error(error) VALUES(?)"); $sth->execute("undeliverable"); $sth->finish; my $undeliverableId = $sp->dbh->last_insert_id("","","delivery_error",""); +$val = -1; +lives_ok { $val = $sp->_lookupDeliveryError("undeliverable"); }, + "_lookupDeliveryError: succeeds for known error ..."; +is($val, $undeliverable, "_lookupDeliveryError: ... and returns proper id number"); + dies_ok { $sp->addEmailError(undef); } "addEmailError: undef argument dies.";