Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tests: clearly should be ok(), not is().

Browse source 
This was a Boolean test, so it clearly should be ok(), not an is().
This commit is contained in:
Bradley M. Kuhn 2017-11-26 14:30:44 -08:00
parent faf1a239a4
commit a3ea7a58df
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Supporters/t/Supporters.t
View file

@ -772,7 +772,7 @@ lives_ok { $newFRID = $sp->fulfillRequest( { donorId => $drapperId,
how => "mailed" }); } how => "mailed" }); }
"fulfillRequest: succeeds once the request is no longer on hold..."; "fulfillRequest: succeeds once the request is no longer on hold...";
is( (defined $newFRID and looks_like_number($newFRID) and $newFRID > 0 and ($newFRID != $fulfillRequestId)), ok( (defined $newFRID and looks_like_number($newFRID) and $newFRID > 0 and ($newFRID != $fulfillRequestId)),
"....id returned on successful fulfillRequest() is a number and is not the one returned by previous"); "....id returned on successful fulfillRequest() is a number and is not the one returned by previous");
lives_ok { $tt = $sp->getRequest({donorId => $drapperId, requestTypeId => $tShirt0RequestTypeId } ); } lives_ok { $tt = $sp->getRequest({donorId => $drapperId, requestTypeId => $tShirt0RequestTypeId } ); }