_getOrCreateRequestConfiguration: error conditions
These tests now pass: ok 110 - _getOrCreateRequestConfiguration: dies on empty hash ok 111 - _getOrCreateRequestConfiguration: dies for string requestConfigurationId ok 112 - _getOrCreateRequestConfiguration: dies for non-existant requestConfigurationId ok 113 - _getOrCreateRequestConfiguration: dies for string request id ok 114 - _getOrCreateRequestConfiguration: dies for non-existant requestTypeId
This commit is contained in:
		
							parent
							
								
									9dcea735f4
								
							
						
					
					
						commit
						8f22a89a47
					
				
					 1 changed files with 26 additions and 0 deletions
				
			
		|  | @ -613,6 +613,32 @@ sub _getOrCreateRequestType($$) { | |||
|   delete $params->{requestType}; | ||||
| } | ||||
| 
 | ||||
| =item _getOrCreateRequestConfiguration | ||||
| 
 | ||||
| Arguments: | ||||
| 
 | ||||
| =over | ||||
| 
 | ||||
| =item $params (hash reference) | ||||
| 
 | ||||
| This hash reference usually contains other paramaters, too, but this method | ||||
| looks only at the keys C<requestTypeId>, C<requestConfiguration> and | ||||
| C<requestConfigurationId>.  If C<requestConfigurationId> is set, it simply | ||||
| deletes the C<requestConfiguration> parameter and verifies c<reuqestTypeId> | ||||
| is in the request_type table. | ||||
| 
 | ||||
| =cut | ||||
| 
 | ||||
| sub _getOrCreateRequestConfiguration($$) { | ||||
|   my($self, $params) = @_; | ||||
| 
 | ||||
|   die "_getOrCreateRequestConfiguration: requestTypeId is required" unless defined $params->{requestTypeId}; | ||||
|   my $id = $params->{requestTypeId}; | ||||
|   die "_getOrCreateRequestConfiguration: requestTypeId must be a number" unless looks_like_number($id); | ||||
|   die "_getOrCreateRequestConfiguration: requestTypeId is unknown" unless $self->_verifyRequestTypeId($id); | ||||
| 
 | ||||
| } | ||||
| 
 | ||||
| =item _beginWork() | ||||
| 
 | ||||
| Parameters: | ||||
|  |  | |||
		Loading…
	
	Add table
		
		Reference in a new issue
	
	 Bradley M. Kuhn
						Bradley M. Kuhn