Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Test begin work/commit nesting in a few places.

Browse source 
I discovered a bug where _beginWork() and _commit() calls were not
properly matched.  These tests are added to find them.
This commit is contained in:
Bradley M. Kuhn 2015-12-20 18:49:52 -08:00
parent 5a37adc626
commit 794d34a79f
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Supporters/t/Supporters.t
View file

@ -5,7 +5,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 154; use Test::More tests => 158;
use Test::Exception; use Test::Exception;
use Scalar::Util qw(looks_like_number reftype); use Scalar::Util qw(looks_like_number reftype);
@ -223,6 +223,8 @@ my $tShirt0Data;
dies_ok { $sp->addRequestConfigurations('t-shirt-1', [ @sizeList, 'Men2XL']) } dies_ok { $sp->addRequestConfigurations('t-shirt-1', [ @sizeList, 'Men2XL']) }
"addRequestConfigurations: dies with duplicate items on configuration list."; "addRequestConfigurations: dies with duplicate items on configuration list.";
is($sp->{__NESTED_TRANSACTION_COUNTER__}, 0, "addRequestConfigurations: assure proper beginWork/commit matching.");
is_deeply($sp->getRequestConfigurations('t-shirt-1'), undef, is_deeply($sp->getRequestConfigurations('t-shirt-1'), undef,
"addRequestConfigurations/getRequestConfigurations: add fails with undefined configuration list"); "addRequestConfigurations/getRequestConfigurations: add fails with undefined configuration list");
@ -232,6 +234,8 @@ lives_ok { $tShirt0Data = $sp->addRequestConfigurations('t-shirt-0', \@sizeList)
is( keys %{$tShirt0Data}, ($tShirt0RequestTypeId), is( keys %{$tShirt0Data}, ($tShirt0RequestTypeId),
"addRequestConfigurations: reuses same requestTypeId on add of configurations"); "addRequestConfigurations: reuses same requestTypeId on add of configurations");
is($sp->{__NESTED_TRANSACTION_COUNTER__}, 0, "addRequestConfigurations: assure proper beginWork/commit matching.");
my $cnt = 0; my $cnt = 0;
foreach my $size (@sizeList) { foreach my $size (@sizeList) {
ok( (defined $tShirt0Data->{$tShirt0RequestTypeId}{$size} and ok( (defined $tShirt0Data->{$tShirt0RequestTypeId}{$size} and
@ -256,6 +260,8 @@ dies_ok { $sp->addRequest({ supporterId => 0, requestTypeId => $tShirt0RequestTy
dies_ok { $sp->addRequest({ supporterId => $drapperId, requestTypeId => 0 }); } dies_ok { $sp->addRequest({ supporterId => $drapperId, requestTypeId => 0 }); }
"addRequest: dies if requestTypeId invalid."; "addRequest: dies if requestTypeId invalid.";
is($sp->{__NESTED_TRANSACTION_COUNTER__}, 0, "addRequest: assure proper beginWork/commit matching.");
my $emailListRequestId; my $emailListRequestId;
lives_ok { $emailListRequestId = lives_ok { $emailListRequestId =
@ -458,11 +464,12 @@ lives_ok { $ret = $sp->setPreferredEmailAddress($drapperId, 'drapper@example.org
ok( (defined $ret and looks_like_number($ret) and $ret == $drapperEmailId), ok( (defined $ret and looks_like_number($ret) and $ret == $drapperEmailId),
"setPreferredEmailAddress: ... and returns correct email_address_id on success"); "setPreferredEmailAddress: ... and returns correct email_address_id on success");
is($sp->{__NESTED_TRANSACTION_COUNTER__}, 0, "setPreferredEmailAddress: assure proper beginWork/commit matching.");
lives_ok { $ret = $sp->getPreferredEmailAddress($drapperId) } lives_ok { $ret = $sp->getPreferredEmailAddress($drapperId) }
"getPreferredEmailAddress: lookup of known preferred email address succeeds... "; "getPreferredEmailAddress: lookup of known preferred email address succeeds... ";
is($ret, 'drapper@example.org', "getPreferredEmailAddress: ....and returns the correct value."); is($ret, 'drapper@example.org', "getPreferredEmailAddress: ....and returns the correct value.");
=back =back
=item Internal methods used only by the module itself. =item Internal methods used only by the module itself.