Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

holdRequest(): holdReleaseDate is required.

Browse source 
holdReleaseDate is now a required argument for holdRequest().
This commit is contained in:
Bradley M. Kuhn 2017-01-14 14:43:01 -08:00
parent 2877cd0a2a
commit 68133e8cee
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Supporters/t/Supporters.t
View file

@ -578,7 +578,7 @@ is_deeply($val, { $drapperTShirt0HoldId => { id => $drapperTShirt0HoldId, hold_d
"holdRequest: database entry from successful return is correct"); "holdRequest: database entry from successful return is correct");
my $badHold; my $badHold;
lives_ok { $badHold = $sp->holdRequest( { donorId => $drapperId, who => 'john', lives_ok { $badHold = $sp->holdRequest( { donorId => $drapperId, who => 'john', holdReleaseDate => '1983-01-05',
requestType => "does-not-exist", requestType => "does-not-exist",
heldBecause => "in-person delivery" }); } heldBecause => "in-person delivery" }); }
"holdRequest: attempt to hold a request never made does not die..."; "holdRequest: attempt to hold a request never made does not die...";
@ -591,13 +591,13 @@ is($sp->getRequestType("does-not-exist"), undef,
my $reHoldId; my $reHoldId;
dies_ok { $reHoldId = $sp->holdRequest( { donorId => $drapperId, dies_ok { $reHoldId = $sp->holdRequest( { donorId => $drapperId, holdReleaseDate => '2112-05-15',
requestType => "t-shirt-0", who => 'peggy', requestType => "t-shirt-0", who => 'peggy',
heldBecause => "will leave in his office." }); } heldBecause => "will leave in his office." }); }
"holdRequest: attempt to hold an already-hold request dies ..."; "holdRequest: attempt to hold an already-hold request dies ...";
my $holdRequest; my $holdRequest;
lives_ok { $newHoldId = $sp->holdRequest( { donorId => $olsonId, lives_ok { $newHoldId = $sp->holdRequest( { donorId => $olsonId, holdReleaseDate => '2048-05-15',
requestTypeId => $tShirt0RequestTypeId, who => 'john', requestTypeId => $tShirt0RequestTypeId, who => 'john',
heldBecause => "will delivery at conference" }); } heldBecause => "will delivery at conference" }); }
"holdRequest: succeeds for existing request, using requestTypeId"; "holdRequest: succeeds for existing request, using requestTypeId";