Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

_getOrCreateRequestConfiguration:Refine unit tests

Browse source 
The unit tests had some bugs, which are herein fixed.
This commit is contained in:
Bradley M. Kuhn 2015-12-20 12:09:52 -08:00
parent 92d36a4039
commit 5e03ffd74d
1 changed files with 24 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
Supporters/t/Supporters.t
View file

@ -5,7 +5,7 @@
use strict; use strict;
use warnings; use warnings;
use Test::More tests => 125; use Test::More tests => 127;
use Test::Exception; use Test::Exception;
use Scalar::Util qw(looks_like_number reftype); use Scalar::Util qw(looks_like_number reftype);
@ -468,30 +468,44 @@ dies_ok { $tempSP->_getOrCreateRequestConfiguration(\%hh); }
$val = $tempSP->dbh()->selectall_hashref("SELECT id, description FROM request_configuration", 'description'); $val = $tempSP->dbh()->selectall_hashref("SELECT id, description FROM request_configuration", 'description');
ok((not defined $val), ok((defined $val and (keys(%$val) == 0)),
"_getOrCreateRequestConfiguration: no request_configuration record added for failed attempts"); "_getOrCreateRequestConfiguration: no request_configuration record added for failed attempts");
%hh = ( requestTypeId => $rr, requestConfiguration => 'test-request-config' ); %hh = ( requestTypeId => $rr, requestConfiguration => 'test-request-config' );
lives_ok { $tempSP->_getOrCreateRequestConfiguration(\%hh); } lives_ok { $tempSP->_getOrCreateRequestConfiguration(\%hh); }
"_getOrCreateRequestConfiguration: succeeds with requestConfiguration and requestType"; "_getOrCreateRequestConfiguration: succeeds with requestConfiguration and requestType";
my $rc; my($fullConfig, $rc);
lives_ok { $rc = $tempSP->getRequestType("test-request"); } lives_ok { $fullConfig = $tempSP->getRequestConfigurations('test-request'); }
"_getOrCreateRequestConfiguration: lookup of a request works after _getOrCreateRequestConfiguration"; "getRequestConfigurations: succeeds after successful _getOrCreateRequestConfiguration()";
ok( (defined $rc and looks_like_number($rc) and $rc > 0), $rc = $fullConfig->{$rr}{'test-request-config'};
"_getOrCreateRequestConfiguration: returns valid id of requestConfiguration created");
is_deeply(\%hh, { requestTypeId => $rr, requestConfiguration => $rc }, is_deeply(\%hh, { requestTypeId => $rr, requestConfigurationId => $rc },
"_getOrCreateRequestConfiguration: modification of paramater argument was correct after successful add");
use Data::Dumper;
print Data::Dumper->Dump( [ \%hh ]);
is_deeply $fullConfig,
{ 1 => { 'test-request-config' => 1 } },
"_getOrCreateRequestConfiguration: lookup of a request configuration works after _getOrCreateRequestConfiguration";
%hh = (requestTypeId => $rr, requestConfiguration => "test-request-config");
lives_ok { $tempSP->_getOrCreateRequestConfiguration(\%hh); }
"_getOrCreateRequestConfiguration: looks up one previously added by _getOrCreateRequestConfiguration()";
is_deeply(\%hh, { requestTypeId => $rr, requestConfigurationId => $rc },
"_getOrCreateRequestConfiguration: lookup of a request works after _getOrCreateRequestConfiguration"); "_getOrCreateRequestConfiguration: lookup of a request works after _getOrCreateRequestConfiguration");
%hh = ( requestTypeId => $rr, requestConfigurationId => $rc, requestConfiguration => 'this-arg-matters-not' ); %hh = ( requestTypeId => $rr, requestConfigurationId => $rc, requestConfiguration => 'this-arg-matters-not' );
lives_ok { $tempSP->_getOrCreateRequestConfiguration(\%hh); } lives_ok { $tempSP->_getOrCreateRequestConfiguration(\%hh); }
"_getOrCreateRequestConfiguration: lookup of existing requestConfiguration suceeds."; "_getOrCreateRequestConfiguration: lookup of existing requestConfigurationId succeeds, ignoring requestConfiguration parameter.";
is_deeply(\%hh, { requestTypeId => $rr, requestConfigurationId => $rc }, is_deeply(\%hh, { requestTypeId => $rr, requestConfigurationId => $rc },
"_getOrCreateRequestConfiguration: deletes requestType if both are provided."); "_getOrCreateRequestConfiguration: deletes requestTypeConfiguration if both are provided.");
=back =back