holdRequest: 2 minor bug fixes on parameter names.

I should be more standardized on these parameters and also write tests
to find this stuff.
This commit is contained in:
Bradley M. Kuhn 2016-12-09 13:47:18 -08:00
parent 460352b7c4
commit 5458c0fbc4

View file

@ -1131,7 +1131,7 @@ sub getRequest($$;$) {
if (defined $holdReq and defined $holdReq->{$requestId} and defined $holdReq->{$requestId}{id}) {
return undef if $ignoreHeldRequests and ($TODAY le $holdReq->{$requestId}{release_date});
$rsp->{holdDate} = $holdReq->{$requestId}{hold_date};
$rsp->{releaseDate} = $holdReq->{$requestId}{release_date};
$rsp->{holdReleaseDate} = $holdReq->{$requestId}{release_date};
$rsp->{holder} = $holdReq->{$requestId}{who};
$rsp->{heldBecause} = $holdReq->{$requestId}{why};
}
@ -1392,7 +1392,7 @@ sub holdRequest($$) {
"request_hold(request_id, who, why, release_date, hold_date) " .
"VALUES(?, ?, ? , ? , date('now'))");
$sth->execute($requestId, $params->{who}, $params->{heldBecause}, $params->{releaseDate});
$sth->execute($requestId, $params->{who}, $params->{heldBecause}, $params->{holdReleaseDate});
$sth->finish;
$self->_commit;
$holdRecord = $self->dbh()->selectall_hashref($holdLookupSql, "request_id");