Conservancy/supporters
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix typos in SQL and return value.

Browse source 
This causes the basic add test to finally pass:

ok 70 - fulfillRequest: succeeds for existing request
This commit is contained in:
Bradley M. Kuhn 2015-12-20 16:58:13 -08:00
parent a1f00e68a0
commit 3b3ee21288
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Supporters/lib/Supporters.pm
View file

@ -709,21 +709,21 @@ sub fulfillRequest($$) {
my $requestId = $self->getRequest($supporterId, $params->{requestType});
return undef if not defined $requestId;
my $fulfillLookupSql = "SELECT * FROM fulfillment WHERE request_id = " .
my $fulfillLookupSql = "SELECT id, request_id FROM fulfillment WHERE request_id = " .
$self->dbh->quote($requestId, 'SQL_INTEGER');
my $fulfillRecord = $self->dbh()->selectall_hashref($fulfillLookupSql, "request_id");
if (not defined $fulfillRecord and not defined $fulfillRecord->{$requestId}) {
if (not defined $fulfillRecord or not defined $fulfillRecord->{$requestId}) {
$self->_beginWork;
my $sth->prepare("INSERT INTO fulfillment(request_id, who, how, date) " .
"VALUES(? , ? , ? , date('now');");
my $sth = $self->dbh->prepare("INSERT INTO fulfillment(request_id, who, how, date) " .
"VALUES(? , ? , ? , date('now'))");
$sth->execute($requestId, $params->{who}, $params->{how});
$sth->finish;
$self->_commit;
$fulfillRecord = $self->dbh()->selectall_hashref($fulfillLookupSql, "request_id");
$fulfillRecord = $self->dbh()->selectall_hashref($fulfillLookupSql, "request_id");
}
return $fulfillRecord->{$requestId};
return $fulfillRecord->{$requestId}{id};
}
######################################################################