Conservancy/reimbursinator
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Changed error status to 409, which makes more sense.

Browse source
This commit is contained in:
kououken 2019-02-19 15:33:01 -08:00
parent deabfa8dd1
commit c899263f0c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
back/backend/views.py
View file

@ -200,7 +200,7 @@ def report_detail(request, report_pk):
elif request.method == 'PUT': elif request.method == 'PUT':
rep = Report.objects.get(id=report_pk) rep = Report.objects.get(id=report_pk)
if rep.submitted == True: if rep.submitted == True:
return JsonResponse({"message": "Cannot submit a report that has already been submitted."}, status=400) return JsonResponse({"message": "Cannot submit a report that has already been submitted."}, status=409)
rep.submitted = True; rep.submitted = True;
rep.save() rep.save()
# Send email here # Send email here
@ -211,7 +211,7 @@ def report_detail(request, report_pk):
elif request.method == 'DELETE': elif request.method == 'DELETE':
r = Report.objects.get(id=report_pk) r = Report.objects.get(id=report_pk)
if r.submitted == True: if r.submitted == True:
return JsonResponse({"message": "Cannot delete a report that has been submitted."}, status=400) return JsonResponse({"message": "Cannot delete a report that has been submitted."}, status=409)
# get corresponding sections # get corresponding sections
section_set = Section.objects.filter(report_id=report_pk) section_set = Section.objects.filter(report_id=report_pk)
for i in section_set: for i in section_set:
@ -252,7 +252,7 @@ def section(request, report_pk, section_pk):
# Check that the report isn't submitted # Check that the report isn't submitted
if Section.objects.get(id=section_pk).report_id.submitted: if Section.objects.get(id=section_pk).report_id.submitted:
return JsonResponse({"message": "Cannot update a report that has been submitted."}, status=400) return JsonResponse({"message": "Cannot update a report that has been submitted."}, status=409)
for key in request.data: for key in request.data:
# get the matching field object # get the matching field object