Move 'die' to right place in outer loop; improve regex for diffstat summary line.

This commit is contained in:
Bradley M. Kuhn 2013-08-15 20:52:54 -04:00
parent ba087e3285
commit c555532725

View file

@ -46,14 +46,14 @@ for my $file (<*.diffstat>) {
my %commit; my %commit;
open(DIFFSTAT, "<", $file) or die "unable to open $file for reading: $!"; open(DIFFSTAT, "<", $file) or die "unable to open $file for reading: $!";
while (my $line = <DIFFSTAT>) { while (my $line = <DIFFSTAT>) {
if ($line =~ /^\s*(\d+)files\s+changed\s*,\s+(\d+)insertions[^\d]+\s+(\d+) deletions.*$/) { if ($line =~ /^\s*(\d+)\s*files\s+changed\s*,\s*(\d+)\s*insertion[^\d]+\s+(\d+)\s*deletion.*$/) {
($commit{files}, $commit{insertions}, $commit{deletions}) = ($1, $2, $3); ($commit{files}, $commit{insertions}, $commit{deletions}) = ($1, $2, $3);
last; last;
} }
die "unable to find diffstat summary line in $file"
unless defined $commit{files} and defined $commit{insertions}
and defined $commit{deletions};
} }
die "unable to find diffstat summary line in $file"
unless defined $commit{files} and defined $commit{insertions}
and defined $commit{deletions};
close DIFFSTAT; die "error reading $file: $!" unless ($? == 0); close DIFFSTAT; die "error reading $file: $!" unless ($? == 0);
$commitTotals{$commitID} = \%commit; $commitTotals{$commitID} = \%commit;
} }